1264061 - HTML forms validity popup is often positioned wrongly

Status: RESOLVED DUPLICATE of bug 1262332

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Load http://jsbin.com/yixamu/edit?html,output
Click 'submit form'

The popup is often too high up. The location may depend on which toolbars are visible.

Comment 1

[Andrew Overholt [:overholt]]

It looks like it works in the standalone case: http://output.jsbin.com/yixamu

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

yeah. Perhaps some code isn't dealing with iframes properly?

John, maybe you could take a look at this after bug 1088761?

Comment 3

[John Dai[:jdai]]

(In reply to Olli Pettay [:smaug] from comment #2)
> yeah. Perhaps some code isn't dealing with iframes properly?
> 
> John, maybe you could take a look at this after bug 1088761?

Yes, sure. Let me take this bug. :)

Comment 4

[John Dai[:jdai]]

Attachment: Bug 1264061 - Modify HTML forms validity popup position in iframe.

Just like comment 2 said, it only happens in iframe case. I have verified manually with http://jsbin.com/yixamu/edit?html,output

Hi Olli, may I have your review? Thank you.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8749523 [details] [diff] [review]
Bug 1264061 - Modify HTML forms validity popup position in iframe.

Given that this shows a bug in the patch for bug 691601, perhaps felipe could review this. (I'm not a toolkit peer)

Comment 6

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8749523 [details] [diff] [review]
Bug 1264061 - Modify HTML forms validity popup position in iframe.

Review of attachment 8749523 [details] [diff] [review]:
-----------------------------------------------------------------

A similar (or perhaps just the same?) issue is being fixed in bug 1262332. Neil is adding a new function that handles transforms, and the patch also removes the function that is being changed here. Please take a look to see if that patch is enough to fix this bug too, or if it can be used to more simply fix it

Comment 7

[Neil Deakin]

Yes, the patch in bug 1262332 fixes this and merges the two bits of mostly duplicated code.