1264175 - Remove FetchEvent.isReload

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, task, P2)

Description

[Ben Kelly [:bkelly, not reviewing]]

We have decided to remove FetchEvent.isReload in favor of exposing FetchEvent.request.cache policy values:

  https://github.com/slightlyoff/ServiceWorker/issues/873

I'm filing this now, but we should wait to actually remove it until chrome is ready.  Right now they still need to implement RequestCache.

Comment 1

[Jens Stutte [:jstutte]]

:sbalaji seems no longer active. What should we do with this?

Comment 2

[Perry Jiang [:perry] [no longer employee, use ni?]]

This is a really quick fix, I'll take it.

Comment 3

[Perry Jiang [:perry] [no longer employee, use ni?]]

Attachment: Bug 1264175 - remove FetchEvent.isReload r?#dom-workers-and-storage-reviewers,valentin

isReload is no longer a property defined by the FetchEvent specification.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86d1da74131f
remove FetchEvent.isReload r=dom-workers-and-storage-reviewers,valentin,sg,bzbarsky

Comment 5

[Stefan Hindli [:stefan_hindli]]

Backed out changeset 86d1da74131f (Bug 1264175) for causing mochitest failures in dom/serviceworkers/test/test_fetch_event.html CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=04301c0211e980ca3dd74358685ceead80470655&selectedJob=286283682

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=286283682&repo=autoland&lineNumber=3170

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/975f76d04c40
Backed out changeset 86d1da74131f for causing mochitest failures in dom/serviceworkers/test/test_fetch_event.html CLOSED TREE

Comment 7

[Perry Jiang [:perry] [no longer employee, use ni?]]

Fixed dom/serviceworkers/test/test_fetch_event.html
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4719c7553531f864ca05d5d1d3ac4170703800df

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df18f76d934a
remove FetchEvent.isReload r=dom-workers-and-storage-reviewers,valentin,sg,bzbarsky

Comment 9

[Kohei]

Posted site compatibility note.

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/df18f76d934a

Comment 11

[Eric Shepherd [:sheppy]]

Documentation updated:

• https://developer.mozilla.org/en-US/docs/Web/API/FetchEvent/FetchEvent
• https://wiki.developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/74
• Also submitted BCD PR 5728 to mark isReload as obsolete.