1264247 - Update im/installer/makefile and im/installer/package-manifest

Status: RESOLVED FIXED

(Instantbird Graveyard :: Other, defect)

Description

[aleth [:aleth]]

Update im/installer/makefile and im/installer/package-manifest

Comment 1

[aleth [:aleth]]

Attachment: Update im/installer/makefile and im/installer/package-manifest

Comment 2

[aleth [:aleth]]

Selected from a diff with browser/. Includes
- minor reordering to make future comparisons easier
- make xpcom section an exact copy
- include Bug 1110760 and bug 1204202
- package some missing files

Comment 3

[Patrick Cloke [:clokep]]

Comment on attachment 8740889 [details] [diff] [review]
Update im/installer/makefile and im/installer/package-manifest

Review of attachment 8740889 [details] [diff] [review]:
-----------------------------------------------------------------

Seems sane. I wish we had Windows nightlies going to test this with. Please fix the commit message before pushing.

Comment 4

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/d9c17990eb00cf353776d842485ed16f10ae18fa
Bug 1264247 - Update im/installer/makefile and im/installer/package-manifest. r=clokep

Comment 5

[aleth [:aleth]]

Attachment: Followup to update im/app/makefile.in as well

Adds the missing blocklist rule. Was there a reason the (IFLAGS1) and LOWER_MAC_APP_NAME was missing in various places?

Comment 6

[Florian Quèze [:florian]]

Comment on attachment 8741318 [details] [diff] [review]
Followup to update im/app/makefile.in as well

Review of attachment 8741318 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to aleth [:aleth] from comment #5)

> Was there a reason the (IFLAGS1) and
> LOWER_MAC_APP_NAME was missing in various places?

I don't know about the IFLAGS1, adding it seems to be an improvement.

LOWER_MAC_APP_NAME is Thunderbird specific (see http://mxr.mozilla.org/comm-central/search?string=LOWER_MAC_APP_NAME). I don't mind if you add it to im/ for easier future diffing though (seems to be what has been done for suite/). For Instantbird, CFBundleIdentifier is hardcoded: http://mxr.mozilla.org/comm-central/source/im/app/macbuild/Contents/Info.plist.in#13 And for Firefox it's the MOZ_MACBUNDLE_ID variable: http://mxr.mozilla.org/comm-central/source/mozilla/browser/app/macbuild/Contents/Info.plist.in#151

Comment 7

[aleth [:aleth]]

Attachment: Followup to update im/app/makefile.in as well

Use mail/app/blocklist.xml.

Comment 8

[aleth [:aleth]]

Attachment: Add blocklist prefs

I don't know if there is a non-app-specific response to these pings though.

Comment 9

[aleth [:aleth]]

Attachment: Add blocklist prefs

Don't set url prefs to avoid blocklist pings.

Comment 10

[aleth [:aleth]]

Comment on attachment 8741421 [details] [diff] [review]
Add blocklist prefs

r=florian over IRC.

f?clokep for the appropriate cert pinning pref value (I guess you know more about that than me).

Comment 11

[Patrick Cloke [:clokep]]

Comment on attachment 8741421 [details] [diff] [review]
Add blocklist prefs

Review of attachment 8741421 [details] [diff] [review]:
-----------------------------------------------------------------

https://dxr.mozilla.org/comm-central/source/mozilla/security/certverifier/CertVerifier.h#101

Looks like we'd want 1 or 0 (disabled).

Comment 12

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/f2ceef87101203f6113998b279c923280121bc64
Bug 1264247 - Followup to update im/app/makefile.in as well. r=florian

https://hg.mozilla.org/comm-central/rev/30b93a8fb32328118cf778cf7dc16791607e4998
Bug 1264247 - Add blocklist prefs. r=florian