Closed Bug 1264247 Opened 4 years ago Closed 4 years ago

Update im/installer/makefile and im/installer/package-manifest

Categories

(Instantbird :: Other, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Instantbird 48

People

(Reporter: aleth, Assigned: aleth)

Details

Attachments

(3 files, 2 obsolete files)

Update im/installer/makefile and im/installer/package-manifest
Selected from a diff with browser/. Includes
- minor reordering to make future comparisons easier
- make xpcom section an exact copy
- include Bug 1110760 and bug 1204202
- package some missing files
Comment on attachment 8740889 [details] [diff] [review]
Update im/installer/makefile and im/installer/package-manifest

Review of attachment 8740889 [details] [diff] [review]:
-----------------------------------------------------------------

Seems sane. I wish we had Windows nightlies going to test this with. Please fix the commit message before pushing.
Attachment #8740889 - Flags: review?(clokep) → review+
https://hg.mozilla.org/comm-central/rev/d9c17990eb00cf353776d842485ed16f10ae18fa
Bug 1264247 - Update im/installer/makefile and im/installer/package-manifest. r=clokep
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 48
Version: 50 → 48
Adds the missing blocklist rule. Was there a reason the (IFLAGS1) and LOWER_MAC_APP_NAME was missing in various places?
Attachment #8741318 - Flags: review?(florian)
Comment on attachment 8741318 [details] [diff] [review]
Followup to update im/app/makefile.in as well

Review of attachment 8741318 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to aleth [:aleth] from comment #5)

> Was there a reason the (IFLAGS1) and
> LOWER_MAC_APP_NAME was missing in various places?

I don't know about the IFLAGS1, adding it seems to be an improvement.

LOWER_MAC_APP_NAME is Thunderbird specific (see http://mxr.mozilla.org/comm-central/search?string=LOWER_MAC_APP_NAME). I don't mind if you add it to im/ for easier future diffing though (seems to be what has been done for suite/). For Instantbird, CFBundleIdentifier is hardcoded: http://mxr.mozilla.org/comm-central/source/im/app/macbuild/Contents/Info.plist.in#13 And for Firefox it's the MOZ_MACBUNDLE_ID variable: http://mxr.mozilla.org/comm-central/source/mozilla/browser/app/macbuild/Contents/Info.plist.in#151
Attachment #8741318 - Flags: review?(florian) → review+
Attachment #8741318 - Flags: review+ → review-
Use mail/app/blocklist.xml.
Attached patch Add blocklist prefs (obsolete) — Splinter Review
I don't know if there is a non-app-specific response to these pings though.
Attachment #8741368 - Flags: review+
Attachment #8741370 - Flags: review?(florian)
Attachment #8741318 - Attachment is obsolete: true
Don't set url prefs to avoid blocklist pings.
Attachment #8741370 - Attachment is obsolete: true
Attachment #8741370 - Flags: review?(florian)
Comment on attachment 8741421 [details] [diff] [review]
Add blocklist prefs

r=florian over IRC.

f?clokep for the appropriate cert pinning pref value (I guess you know more about that than me).
Attachment #8741421 - Flags: review+
Attachment #8741421 - Flags: feedback?(clokep)
Comment on attachment 8741421 [details] [diff] [review]
Add blocklist prefs

Review of attachment 8741421 [details] [diff] [review]:
-----------------------------------------------------------------

https://dxr.mozilla.org/comm-central/source/mozilla/security/certverifier/CertVerifier.h#101

Looks like we'd want 1 or 0 (disabled).
Attachment #8741421 - Flags: feedback?(clokep) → feedback+
You need to log in before you can comment on or make changes to this bug.