1264334 - Tab sharing follows tab activations across windows

Status: RESOLVED INCOMPLETE

(Hello (Loop) :: Client, defect)

Description

[Ian Bicking (:ianbicking)]

To reproduce:

1. Open two Firefox windows
2. Start a Hello conversation with another person/browser in window 1
3. In window 2, change tabs

The newly-active tab in window 2 will be shared (both as a context tile, and the video of the tab).

Focusing a window does not cause the active tab in the window to be shared, it requires that you change tabs in that window.

Expected behavior:

Only the tabs from the window where Hello is open, and where the infobar is displaying, will be shared.

Comment 1

[Ian Bicking (:ianbicking)]

The reproduction is a little harder:

1. Open two Firefox windows
2. Start Hello in window 1
3. Quickly switch to window 2
4. Now both window 1 and window 2 tabs can be shared
5. Stop Hello
6. Start Hello in window 1, let it complete
7. Change tabs in window 2, the tab will now be shared

Once the first case happens (window switch during Hello startup) it will affect future sessions.

Comment 2

[Mark Banner (:standard8)]

Ok, I dug down. There's really two issues here:

1) Hello shouldn't share tabs in a window where you didn't open the conversation window.
2) When we stop sharing, although we attempt to, the TabSelect listener doesn't actually get removed. This causes the effect seen at item 7 in comment 1.

The first we can fix ourselves - we need to look at which window the conversation window is in.

The second we either need to get the bug I just filed fixed (bug 1264383), or we need to get bug 1262560 fixed...

Comment 3

[Mark Banner (:standard8)]

Support for Hello/Loop has been discontinued.

https://support.mozilla.org/kb/hello-status

Hence closing the old bugs. Thank you for your support.