1264480 - Move Distribution.ReadyCallback @WorkerThread annotation to the individual methods

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

To start, set up a build environment - you can see the instructions here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build

Then, you'll need to create a patch to upload - see
https://wiki.mozilla.org/Mobile/Fennec/Android/Suggested_workflow#Creating_commits_and_submitting_patches

You can find more miscellaneous information at: https://wiki.mozilla.org/Mobile/Fennec/Android

To fix this bug, remove the `@WorkerThread` annotation from ReadyCallback and add one for each of the interface methods. You can find the code here:
  https://dxr.mozilla.org/mozilla-central/rev/21bf1af375c1fa8565ae3bb2e89bd1a0809363d4/mobile/android/base/java/org/mozilla/gecko/distribution/Distribution.java#130

The reason for this change is that the compiler will warn if you construct a class that implements this interface on a thread that doesn't agree with the interface annotation.

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Thanks and happy coding! ^_^

Comment 1

[Jorick Caberio]

Please assign this bug to me.

Comment 2

[Jorick Caberio]

Attachment: bug_1264480_fix.diff

Here's my patch

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8741314 [details] [diff] [review]
bug_1264480_fix.diff

Review of attachment 8741314 [details] [diff] [review]:
-----------------------------------------------------------------

In your commit message, make sure you follow the form, "Bug ### - <msg>. r=<reviewer>"

Otherwise looks good! I pushed it to our try test server: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c25f0694824

::: mobile/android/base/java/org/mozilla/gecko/distribution/Distribution.java
@@ +126,5 @@
>       * When <code>distributionNotFound</code> is called,
>       * {@link org.mozilla.gecko.distribution.Distribution#exists()} will return
>       * false. In the other two callbacks, it will return true.
>       */
> +

nit: please remove this line of whitespace.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/83823a99114c095f1771d9a6b9c7d735dfe25abe
Bug 1264480 - Moved Distribution.ReadyCallback @WorkerThread annotation to the individual methods. r=mcomella

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/83823a99114c