Closed
Bug 1264516
Opened 8 years ago
Closed 8 years ago
[Test] Rename to camel-case for directory of web-animation's web-platform tests.
Categories
(Core :: DOM: Animation, defect)
Core
DOM: Animation
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: mantaroh, Assigned: mantaroh)
Details
Attachments
(2 files)
We should probably rename web-animation's web-platform directory to camel-case.
Comment 1•8 years ago
|
||
I don't think we should change this. This should match the spec's "short name" which is web-animations.
Assignee | ||
Comment 2•8 years ago
|
||
As discussed, I updated the directory of Web Animation API's tests. https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5720dfe6976 Hi Brian, I think that we should make directory like 'programming-interface', if we write the test following specification. (So we can move those tests into testing/web-platform/tests/web-animation/programming-interface.) And we can separate the tests of KeyframeEffect into KeyframeEffect and KeyframeEffectReadOnly. How do you think about this modification?
Flags: needinfo?(bbirtles)
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(bbirtles)
Assignee | ||
Comment 3•8 years ago
|
||
I discussed with Brian. Point of renaming web-platform-tests directories: 1) We have better to create the 'api' directory into testing/web-platform/tests/web-animation. 2) We should separate the tests of KeyframeEffect into KeyframeEffect and KeyframeEffectReadOnly. 3) We don't need to use camel-case in constructor files. (e.g. KeyframeEffect/constructor.html)
Assignee: nobody → mantaroh
Assignee | ||
Comment 4•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c71b88896153
Assignee | ||
Comment 5•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/53390/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/53390/
Attachment #8753608 -
Flags: review?(bbirtles)
Attachment #8753609 -
Flags: review?(bbirtles)
Assignee | ||
Comment 6•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/53392/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/53392/
Assignee | ||
Comment 7•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c76975fd0a0
Comment 8•8 years ago
|
||
Comment on attachment 8753608 [details] MozReview Request: Bug 1264516 - Part1. Rename web-animations test folders in web-platform-tests to align with the spec. r?birtles https://reviewboard.mozilla.org/r/53390/#review50180 This looks good. It took me a while to confirm that the changes to MANIFEST.json are correct but after comparing to what's in web-platform-tests I think this is right. Nit: For the commit message, perhaps "Rename web-animations test folders in web-platform-tests to align with the spec." would be better.
Attachment #8753608 -
Flags: review?(bbirtles) → review+
Assignee | ||
Comment 9•8 years ago
|
||
Comment on attachment 8753608 [details] MozReview Request: Bug 1264516 - Part1. Rename web-animations test folders in web-platform-tests to align with the spec. r?birtles Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53390/diff/1-2/
Attachment #8753608 -
Attachment description: MozReview Request: Bug 1264516 - Part1. Modify the directory name of animation web-platform-tests. r?birtles → MozReview Request: Bug 1264516 - Part1. Rename web-animations test folders in web-platform-tests to align with the spec. r?birtles
Assignee | ||
Comment 10•8 years ago
|
||
Comment on attachment 8753609 [details] MozReview Request: Bug 1264516 - Part2. Move api tests of animation's into interfaces directory. r?birtles Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53392/diff/1-2/
Assignee | ||
Comment 11•8 years ago
|
||
Thanks Brian, As discussed at IRC(#japan channel), I modified sub directory name to 'interfaces'.
Comment 12•8 years ago
|
||
Comment on attachment 8753609 [details] MozReview Request: Bug 1264516 - Part2. Move api tests of animation's into interfaces directory. r?birtles https://reviewboard.mozilla.org/r/53392/#review50184 Nit: The changeset message needs to be updated
Attachment #8753609 -
Flags: review?(bbirtles) → review+
Assignee | ||
Comment 13•8 years ago
|
||
Comment on attachment 8753609 [details] MozReview Request: Bug 1264516 - Part2. Move api tests of animation's into interfaces directory. r?birtles Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53392/diff/2-3/
Attachment #8753609 -
Attachment description: MozReview Request: Bug 1264516 - Part2. Move api tests of animation's into api directory. r?birtles → MozReview Request: Bug 1264516 - Part2. Move api tests of animation's into interfaces directory. r?birtles
Assignee | ||
Comment 14•8 years ago
|
||
https://reviewboard.mozilla.org/r/53392/#review50184 Thanks Brian. I forgot changing commit log.
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 15•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb924656b6f9 https://hg.mozilla.org/integration/mozilla-inbound/rev/0ac8722e275d
Keywords: checkin-needed
Comment 16•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bb924656b6f9 https://hg.mozilla.org/mozilla-central/rev/0ac8722e275d
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•