1264516 - [Test] Rename to camel-case for directory of web-animation's web-platform tests.

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect)

Description

[Mantaroh Yoshinaga[:mantaroh]]

We should probably rename web-animation's web-platform directory to camel-case.

Comment 1

[Brian Birtles (:birtles)]

I don't think we should change this. This should match the spec's "short name" which is web-animations.

Comment 2

[Mantaroh Yoshinaga[:mantaroh]]

As discussed, I updated the directory of Web Animation API's tests.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5720dfe6976

Hi Brian,
I think that we should make directory like 'programming-interface', if we write the test following specification. (So we can move those tests into testing/web-platform/tests/web-animation/programming-interface.)
And we can separate the tests of KeyframeEffect into KeyframeEffect and KeyframeEffectReadOnly.

How do you think about this modification?

Comment 3

[Mantaroh Yoshinaga[:mantaroh]]

I discussed with Brian.

Point of renaming web-platform-tests directories:
 1) We have better to create the 'api' directory into testing/web-platform/tests/web-animation.
 2) We should separate the tests of KeyframeEffect into KeyframeEffect and KeyframeEffectReadOnly.
 3) We don't need to use camel-case in constructor files. (e.g. KeyframeEffect/constructor.html)

Comment 4

[Mantaroh Yoshinaga[:mantaroh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c71b88896153

Comment 5

[Mantaroh Yoshinaga[:mantaroh]]

Attachment: MozReview Request: Bug 1264516 - Part1. Rename web-animations test folders in web-platform-tests to align with the spec. r?birtles

Review commit: https://reviewboard.mozilla.org/r/53390/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53390/

Comment 6

[Mantaroh Yoshinaga[:mantaroh]]

Attachment: MozReview Request: Bug 1264516 - Part2. Move api tests of animation's into interfaces directory. r?birtles

Review commit: https://reviewboard.mozilla.org/r/53392/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53392/

Comment 7

[Mantaroh Yoshinaga[:mantaroh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c76975fd0a0

Comment 8

[Brian Birtles (:birtles)]

Comment on attachment 8753608 [details]
MozReview Request: Bug 1264516 - Part1. Rename web-animations test folders in web-platform-tests to align with the spec. r?birtles

https://reviewboard.mozilla.org/r/53390/#review50180

This looks good. It took me a while to confirm that the changes to MANIFEST.json are correct but after comparing to what's in web-platform-tests I think this is right.

Nit: For the commit message, perhaps "Rename web-animations test folders in web-platform-tests to align with the spec." would be better.

Comment 9

[Mantaroh Yoshinaga[:mantaroh]]

Comment on attachment 8753608 [details]
MozReview Request: Bug 1264516 - Part1. Rename web-animations test folders in web-platform-tests to align with the spec. r?birtles

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53390/diff/1-2/

Comment 10

[Mantaroh Yoshinaga[:mantaroh]]

Comment on attachment 8753609 [details]
MozReview Request: Bug 1264516 - Part2. Move api tests of animation's into interfaces directory. r?birtles

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53392/diff/1-2/

Comment 11

[Mantaroh Yoshinaga[:mantaroh]]

Thanks Brian,

As discussed at IRC(#japan channel), I modified sub directory name to 'interfaces'.

Comment 12

[Brian Birtles (:birtles)]

Comment on attachment 8753609 [details]
MozReview Request: Bug 1264516 - Part2. Move api tests of animation's into interfaces directory. r?birtles

https://reviewboard.mozilla.org/r/53392/#review50184

Nit: The changeset message needs to be updated

Comment 13

[Mantaroh Yoshinaga[:mantaroh]]

Comment on attachment 8753609 [details]
MozReview Request: Bug 1264516 - Part2. Move api tests of animation's into interfaces directory. r?birtles

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53392/diff/2-3/

Comment 14

[Mantaroh Yoshinaga[:mantaroh]]

https://reviewboard.mozilla.org/r/53392/#review50184

Thanks Brian.

I forgot changing commit log.

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bb924656b6f9
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ac8722e275d

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bb924656b6f9
https://hg.mozilla.org/mozilla-central/rev/0ac8722e275d