126463 - Occurances of uninitialized variables being used before being set (in extensions/transformiix).

Status: VERIFIED FIXED

(Core :: XSLT, defect, P3)

Description

[Aleksey Nogin]

This bug is just for the warnings in various source files in
extensions/transformiix/source. Currently
(http://tinderbox.mozilla.org/SeaMonkey/warn1014136200.29882.html - Tue, 19 Feb
2002 11:30 EST) TBox shows the following warnings:

extensions/transformiix/source/xml/parser/nsSyncLoader.cpp:235
 `class txLoadListenerProxy * proxy' might be used uninitialized in this function

extensions/transformiix/source/xpath/ExprParser.cpp:75
 `UNICODE_CHAR endLiteral' might be used uninitialized in this function

extensions/transformiix/source/xpath/XPathProcessor.cpp:49
 `class nsISupports * foundInterface' might be used uninitialized in this function

extensions/transformiix/source/xpath/nsNodeSet.cpp:47
 `class nsISupports * foundInterface' might be used uninitialized in this function

extensions/transformiix/source/xslt/XSLTProcessor.cpp:169
 `class nsISupports * foundInterface' might be used uninitialized in this function

extensions/transformiix/source/xslt/functions/txFormatNumberFunctionCall.cpp:122
 `UNICODE_CHAR c' might be used uninitialized in this function

Comment 1

[Aleksey Nogin]

Bug 59652 is the meta-bug tracking the fight against these (potentially very
nasty) warnings.

P.S. Trying to make sure that 1.0 has as little warnings as possible.

Comment 2

[Peter Van der Beken [:peterv]]

class nsISupports * foundInterface should be filed on the macro
NS_IMPL_QUERY_HEAD. I'll attach a patch for the others.

Comment 3

[Peter Van der Beken [:peterv]]

Attachment: Fix some warnings

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

+    nsCOMPtr<nsIDOMEventReceiver> target = do_QueryInterface(DOMDocument, &rv);
+    NS_ENSURE_SUCCESS(rv, rv);

don't check the error-value from do_QI, NS_ENSURE_TRUE(target) instead (at 
least that's what i've been told is the "right" way)

with that, r=sicking

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 70432 [details] [diff] [review]
Fix some warnings

(no need for new patch)

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

once but 92929 is fixed this shouldn't be a problem ;-)

Comment 7

[scottputterman]

Moving Netscape owned 0.9.9 and 1.0 bugs that don't have an nsbeta1, nsbeta1+,
topembed, topembed+, Mozilla0.9.9+ or Mozilla1.0+ keyword.  Please send any
questions or feedback about this to [e-mail].  You can search for
"Moving bugs not scheduled for a project" to quickly delete this bugmail.

Comment 8

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Looks like proxy is the only unitialized var left and it looks like it could
well be real, so it would be nice to have the fix for this...

I have a fix for 'class nsISupports * foundInterface' stuff.

Comment 9

[Peter Van der Beken [:peterv]]

Attachment: Fix v2

Comment 10

[Peter Van der Beken [:peterv]]

Comment on attachment 74522 [details] [diff] [review]
Fix v2

Moving the r=sicking

Comment 11

[Johnny Stenback (:jst)]

Comment on attachment 74522 [details] [diff] [review]
Fix v2

sr=jst

Comment 12

[Asa Dotzler [:asa]]

Comment on attachment 74522 [details] [diff] [review]
Fix v2

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 13

[Peter Van der Beken [:peterv]]

Checked in.

Comment 14

[Aleksey Nogin]

Verifying, currently
(http://tinderbox.mozilla.org/SeaMonkey/warn1016552220.1515.html - Tue, 19 Mar
2002 10:37 EST) I do not see any such warnings in extensions/transformiix. Thanks!

Comment 15

[Aleksey Nogin]

This have regressed - bug 113611 checkin have added 4 new "might be used
uninitialized" warnings in extensions/transformiix:

+extensions/transformiix/source/xslt/Numbering.cpp:80
+ `enum txNodeTypeTest::NodeType nodetype' might be used uninitialized in this
function
+
+extensions/transformiix/source/xslt/ProcessorState.cpp:194
+ `double priority' might be used uninitialized in this function
+
+extensions/transformiix/source/xslt/ProcessorState.cpp:513
+ `MBool hasAttr' might be used uninitialized in this function
+
+extensions/transformiix/source/xslt/ProcessorState.cpp:555
+ `MBool hasAttr' might be used uninitialized in this function

Comment 16

[Axel Hecht]

This is not a regression, but new occurences.
The code is safe though, I will fix the warnings later on, in a different bug.

Comment 17

[Aleksey Nogin]

Axel, two of the warnings are still there:

extensions/transformiix/source/xslt/Numbering.cpp:80
 `enum txNodeTypeTest::NodeType nodetype' might be used uninitialized in this
function

extensions/transformiix/source/xslt/ProcessorState.cpp:234
 `double priority' might be used uninitialized in this function

Comment 18

[Axel Hecht]

The first one should be part of bug 94036, the second one is wrong anyway.
Anyway, this bug is not about those. The ones that this bug was about have been
fixed.