Closed
Bug 1264717
Opened 9 years ago
Closed 9 years ago
Add extended session store debug logging (behind a pref)
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: JanH, Assigned: JanH)
References
Details
Attachments
(2 files)
To help session store debugging in the wild (e.g. bug 1256277), I'm adding some extended debug logging to sessionstore.js. For the time being, this will only be enabled on Nightly, though.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jh+bugzilla
Assignee | ||
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/46525/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46525/
Attachment #8741519 -
Flags: review?(margaret.leibovic)
Attachment #8741520 -
Flags: review?(margaret.leibovic)
Assignee | ||
Comment 2•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/46527/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46527/
Comment 3•9 years ago
|
||
Comment on attachment 8741519 [details]
MozReview Request: Bug 1264717 - Part 0 - Get rid of unbraced ifs in sessionstore.js. r=margaret
https://reviewboard.mozilla.org/r/46525/#review43781
Attachment #8741519 -
Flags: review?(margaret.leibovic) → review+
Comment 4•9 years ago
|
||
Comment on attachment 8741520 [details]
MozReview Request: Bug 1264717 - Part 1 - Add some debug logging to the session store. r=margaret
https://reviewboard.mozilla.org/r/46527/#review43783
This is a lot of logging... I know I said before it would be fine to land this for Nightly only, but this might really clutter the log for developers who are testing locally. Would it make sense to put this logging behind a gecko pref, which can be set in about:config?
Attachment #8741520 -
Flags: review?(margaret.leibovic)
Assignee | ||
Comment 5•9 years ago
|
||
https://reviewboard.mozilla.org/r/46527/#review43783
Very good idea.
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8741519 [details]
MozReview Request: Bug 1264717 - Part 0 - Get rid of unbraced ifs in sessionstore.js. r=margaret
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46525/diff/1-2/
Attachment #8741520 -
Flags: review?(margaret.leibovic)
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8741520 [details]
MozReview Request: Bug 1264717 - Part 1 - Add some debug logging to the session store. r=margaret
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46527/diff/1-2/
Updated•9 years ago
|
Attachment #8741520 -
Flags: review?(margaret.leibovic) → review+
Comment 8•9 years ago
|
||
Comment on attachment 8741520 [details]
MozReview Request: Bug 1264717 - Part 1 - Add some debug logging to the session store. r=margaret
https://reviewboard.mozilla.org/r/46527/#review44237
Great, I think it's good to use a pref like this. You could also make a post to the mobile-firefox-dev@mozilla.org mailing list mentioning this new support, and asking for help if there's anything you need help debugging.
Assignee | ||
Comment 9•9 years ago
|
||
Keywords: checkin-needed
Assignee | ||
Updated•9 years ago
|
Summary: Add extended session store debug logging in Nightly → Add extended session store debug logging (behind a pref)
Comment 10•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/9a55bb9bae73
https://hg.mozilla.org/integration/fx-team/rev/ec69a0c8c6ef
Keywords: checkin-needed
Comment 11•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9a55bb9bae73
https://hg.mozilla.org/mozilla-central/rev/ec69a0c8c6ef
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•