Closed Bug 1264717 Opened 4 years ago Closed 4 years ago

Add extended session store debug logging (behind a pref)

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: JanH, Assigned: JanH)

References

Details

Attachments

(2 files)

To help session store debugging in the wild (e.g. bug 1256277), I'm adding some extended debug logging to sessionstore.js. For the time being, this will only be enabled on Nightly, though.
Assignee: nobody → jh+bugzilla
Comment on attachment 8741519 [details]
MozReview Request: Bug 1264717 - Part 0 - Get rid of unbraced ifs in sessionstore.js. r=margaret

https://reviewboard.mozilla.org/r/46525/#review43781
Attachment #8741519 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8741520 [details]
MozReview Request: Bug 1264717 - Part 1 - Add some debug logging to the session store. r=margaret

https://reviewboard.mozilla.org/r/46527/#review43783

This is a lot of logging... I know I said before it would be fine to land this for Nightly only, but this might really clutter the log for developers who are testing locally. Would it make sense to put this logging behind a gecko pref, which can be set in about:config?
Attachment #8741520 - Flags: review?(margaret.leibovic)
Comment on attachment 8741519 [details]
MozReview Request: Bug 1264717 - Part 0 - Get rid of unbraced ifs in sessionstore.js. r=margaret

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46525/diff/1-2/
Attachment #8741520 - Flags: review?(margaret.leibovic)
Comment on attachment 8741520 [details]
MozReview Request: Bug 1264717 - Part 1 - Add some debug logging to the session store. r=margaret

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46527/diff/1-2/
Attachment #8741520 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8741520 [details]
MozReview Request: Bug 1264717 - Part 1 - Add some debug logging to the session store. r=margaret

https://reviewboard.mozilla.org/r/46527/#review44237

Great, I think it's good to use a pref like this. You could also make a post to the mobile-firefox-dev@mozilla.org mailing list mentioning this new support, and asking for help if there's anything you need help debugging.
Summary: Add extended session store debug logging in Nightly → Add extended session store debug logging (behind a pref)
https://hg.mozilla.org/mozilla-central/rev/9a55bb9bae73
https://hg.mozilla.org/mozilla-central/rev/ec69a0c8c6ef
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
See Also: → 1617802
You need to log in before you can comment on or make changes to this bug.