Closed Bug 1264726 Opened 8 years ago Closed 8 years ago

WebRTC client throws error when received SDP contains bandwidth fields with unknown modifiers

Categories

(Core :: WebRTC: Signaling, defect, P2)

45 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: rajmohanbanavi, Assigned: drno)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.112 Safari/537.36

Steps to reproduce:

When FF receives an SDP which contains bandwidth attribute with unknown modifiers, it is observed that the setRemoteDesciprion() fails. The SDP which was used in this case contained 2 bandwidth attributes
b=RS:1012
b=RR:3037



Actual results:

It is observed that setRemoteDescription() throws error when it is fed an SDP containing bandwidth attributes such as above.


Expected results:

FF should have ignored these bandwidth attributes (if it does not understand the bandwidth modifiers) and setRemoteDescription() should have succeeded considering that other parts of the SDP were fine.

RFC4566 sec 5.8 mentions that

SDP parsers MUST ignore bandwidth fields with unknown modifiers.
Component: Untriaged → WebRTC: Signaling
Product: Firefox → Core
backlog: --- → webrtc/webaudio+
Rank: 25
Priority: -- → P2
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Unspecified → All
Hardware: Unspecified → All
For quick reference I think this is the point which causes the parsing error: https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/src/sdp/sipcc/sdp_token.c#747
sample sdp 

v=0
o=test 0272121831486145759 1486145759 IN IP4 10.3.12.213
s=test SDP
c=IN IP4 10.3.12.213
b=AS:81
b=RS:1012
b=RR:3037
t=0 0
a=msid-semantic: WMS Rg010o0rWRvQKtOE75wqtOm0kuPBrmQOyBWx
a=ice-lite
a=fingerprint:sha-256
m=audio 6144 UDP/TLS/RTP/SAVPF 0
a=extmap:1 urn:ietf:params:rtp-hdrext:ssrc-audio-level
a=sendrecv
a=rtcp-mux
a=ssrc:211795086 cname:HatG6f2W5UjZtBi5
a=ssrc:211795086 msid:Rg010o0rWRvQKtOE75wqtOm0kuPBrmQOyBWx f401d57a-8e3f-4b1c-a8d4-85910aa48e3a
a=ssrc:211795086 mslabel:Rg010o0rWRvQKtOE75wqtOm0kuPBrmQOyBWx
a=ssrc:211795086 label:f401d57a-8e3f-4b1c-a8d4-85910aa48e3a
a=setup:passive
a=ice-ufrag:KRnO
a=ice-pwd:KRnOUWEHuKgbLUUNAMAoUR
a=candidate:1 1 UDP 2130706431 10.3.12.213 6144 typ host
a=candidate:1 2 UDP 2130706430 10.3.12.213 6145 typ host
a=fingerprint:sha-256  D3:20:F6:20:ED:92:8F:08:52:C9:E9:21:ED:A9:7D:DE:16:F2:1D:6B:24:C4:85:C7:22:5D:F7:89:14:84:62:E1
a=msi:abcdefodi-0-14c-2-2-ffffffff-@10.3.12.212
a=rtpmap:0 PCMU/8000
Assignee: nobody → drno
Comment on attachment 8742021 [details]
MozReview Request: Bug 1264726: ignore unsupported SDP bandwidth parameters. r=bwc

https://reviewboard.mozilla.org/r/46903/#review43869
Attachment #8742021 - Flags: review?(docfaraday) → review+
https://hg.mozilla.org/mozilla-central/rev/92fa6bc494fe
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.