Closed Bug 1264829 Opened 4 years ago Closed 4 years ago

test_classifier.html doesn't really test unwanted.example.com

Categories

(Toolkit :: Safe Browsing, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: dimi, Assigned: dimi)

References

Details

Attachments

(1 file)

Testcase test_classifier.html try to test "unwanted.example.com" by adding the domain to test-unwated-simple database and then check if load "http://unwanted.example.com/tests/toolkit/components/url-classifier/tests/mochitest/evil.css" fails.

But "unwanted.example.com" is not in the server-locations.txt so no matter if the domain is added to database or not. The evil.css will not be loaded.
Hi francois,
I can simply fix this by replacing "unwanted.example.com" with another domain that really exists. But I think maybe add "unwanted.example.com" to server-locations.txt like malware.example.com[1]does is a better way because we may use it in other testcases for safebrowsing in the future.

How do you think ?

[1]https://dxr.mozilla.org/mozilla-central/source/build/pgo/server-locations.txt#170
Flags: needinfo?(francois)
Assignee: nobody → dlee
Status: NEW → ASSIGNED
Blocks: 1264169
(In reply to Dimi Lee[:dimi][:dlee] from comment #1)
> But I think maybe add "unwanted.example.com" to
> server-locations.txt like malware.example.com[1]does is a better way because
> we may use it in other testcases for safebrowsing in the future.

Sounds good to me.
Flags: needinfo?(francois)
Comment on attachment 8742590 [details]
MozReview Request: Bug 1264829 - test_classifier.html doesn't really test unwanted.example.com. r?francois

https://reviewboard.mozilla.org/r/47335/#review44009
Attachment #8742590 - Flags: review?(francois) → review+
Keywords: checkin-needed
(In reply to Pulsebot from comment #7)
> https://hg.mozilla.org/integration/fx-team/rev/9073060fceb0

seems Ryan was a little faster to push this - so backed this out form fx-team since this landed on mozilla-inbound already
https://hg.mozilla.org/mozilla-central/rev/5c0f6e954333
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.