1264878 - [meta] Move nsIEditorMailSupport methods to c-c

Status: NEW

(Core :: DOM: Editor, defect)

Description

[Makoto Kato [:m_kato]]

nsIEditorMailSupport uses on Thunderbird and Seamonkey only.   So we should move these methods to c-c if possible.

Comment 1

[Makoto Kato [:m_kato]]

(and a few addons.  I don't check whether addons is for Firefox)

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Are nsIEditorMailSupport methods used with <textarea> or <input>?

If not, we can move the interface implementation to HTMLEditor. Then, we can reduce footprint 4KB or 8KB per TextEditor instance.

(XUL <editor> element makes XUL document editable, so, it is also creates HTMLEditor.)

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

> 4KB or 8KB per TextEditor instance

Oops, not "K", 4B or 8B.

Comment 4

[Jorg K (CEST = GMT+2)]

(In reply to Masayuki Nakano [:masayuki] (JST, +0900) from comment #2)
> Are nsIEditorMailSupport methods used with <textarea> or <input>?
You're asking me? I think we're only using them on <editor>:
https://dxr.mozilla.org/comm-central/rev/e5e1510b8d914bfa8439b21ba3f73e4f2e83e957/mail/components/compose/content/messengercompose.xul#2053

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Jorg K (GMT+2) from comment #4)
> (In reply to Masayuki Nakano [:masayuki] (JST, +0900) from comment #2)
> > Are nsIEditorMailSupport methods used with <textarea> or <input>?
> You're asking me?

If you'd exactly know, yes, otherwise, not. Just a tweet.

> I think we're only using them on <editor>:
> https://dxr.mozilla.org/comm-central/rev/
> e5e1510b8d914bfa8439b21ba3f73e4f2e83e957/mail/components/compose/content/
> messengercompose.xul#2053

Thanks, can I make TextEditor not inherit nsIEditorMailSupport for making sure that Thunderbird does not use the interface with <input> nor <textarea>? (I mean, if it breaks Tb, just I'll back it out.)

Comment 6

[Jorg K (CEST = GMT+2)]

There are only two <textarea>s in C-C and very few <input>s, mostly in testing. To my knowledge, we don't use nsIEditorMailSupport methods on those. That's all I can say.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Thanks. I'll try to move nsIEditorMailSupport from TextEditor to HTMLEditor.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Masayuki Nakano [:masayuki] (JST, +0900) from comment #7)
> Thanks. I'll try to move nsIEditorMailSupport from TextEditor to HTMLEditor.

I'll work on this in bug 1476897.