Closed
Bug 126498
Opened 22 years ago
Closed 19 years ago
the user can end up with completely empty cards
Categories
(SeaMonkey :: MailNews: Address Book & Contacts, enhancement)
SeaMonkey
MailNews: Address Book & Contacts
Tracking
(Not tracked)
People
(Reporter: sspitzer, Unassigned)
Details
Attachments
(2 files)
18.41 KB,
image/gif
|
Details | |
5.62 KB,
patch
|
standard8
:
review-
|
Details | Diff | Splinter Review |
the user can end up with completely empty cards to reproduce this: edit an addressbook card, and remove all the values. should we prevent the user from hitting "ok" when this will leave them with empty cards? should we tell them to delete it? or am I over-engineering. I wonder was OE does.
Comment 1•22 years ago
|
||
> I wonder was OE does.
Acts weirdly.
If you clear the Display Name for a contact, OE6 will complain with an alert
containing just an OK button. If you press said OK button but then cancel the
changes to the card, OE decides to replace the First and Display Name with
'Unknown'. If you don't activate the alert, Cancel acts normally.
In other words, I can't tell you what OE does as it's too buggy.
Comment 2•22 years ago
|
||
> If you clear the Display Name for a contact, OE6 will complain with an alert
> containing just an OK button.
Er, sorry, shopuld have been clearer. The alert doesn't just have an OK button
(it's not that buggy), it also has some lovely text telling you that you must
supply a Display Name. And then lets you not supply one.
4.x lets you delete everything and click OK. But the card is really still there. It makes it look like its letting you delete all the info, but what it really did is save the info from the very last field from which you deleted info. How about: Display an info dialog when the user clicks "OK" on Card for dialog (and card is empty): "This card contains no information and will be deleted." OK/Cancel OK - delete card. Cancel - return focus to card. I'm guessing its pretty rare someone is gonna get into this situation (unless they are doing testing or truly made a boo boo), so I think its best to throw up a dialog.
Comment 5•21 years ago
|
||
clean up the code a little
Updated•21 years ago
|
QA Contact: nbaca → stolenclover
Updated•21 years ago
|
Attachment #139980 -
Flags: review?(sspitzer)
Updated•20 years ago
|
Product: Browser → Seamonkey
Updated•19 years ago
|
Assignee: sspitzer → mail
Comment 6•19 years ago
|
||
Comment on attachment 139980 [details] [diff] [review] patch v1 Sorry, this isn't what we want in address book - it also doesn't cover the edit card case, see https://bugzilla.mozilla.org/show_bug.cgi?id=64305#c27 for my other comments.
Attachment #139980 -
Flags: review?(sspitzer) → review-
Comment 7•19 years ago
|
||
This is going to be addressed in bug 64305, therefore duping to that one. I'll handle the tidy up seperately if necessary. *** This bug has been marked as a duplicate of 64305 ***
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → DUPLICATE
Updated•19 years ago
|
Severity: normal → enhancement
Status: RESOLVED → VERIFIED
OS: Windows 2000 → All
Hardware: PC → All
You need to log in
before you can comment on or make changes to this bug.
Description
•