1265030 - make NS_ENSURE_SUCCESS (and similar) failure messages tell you the nsresult name, rather than hex code

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nathan Froyd [:froydnj]]

It's 2016, we can translate from hex codes to error names.

As a bonus, we can make the DEBUG implementation of NS_ENSURE_SUCCESS_BODY take up a lot less space than it's doing now.

Comment 1

[Andrew McCreight [:mccr8]]

There was a bug around somewhere on converting nsError to strings, and I even poked at it a bit, but I can't find it now.

Comment 2

[Cameron McCormack (:heycam)]

Attachment: Bug 1265030 - Show symbolic nsresult name in NS_ENSURE_SUCCESS warning.

Through their use of Smprintf, the existing warning message formatting
is resistant to OOM errors. So I figured that we should probably use
something that doesn't infallibly allocate like GetErrorName does.

Comment 3

[Cameron McCormack (:heycam)]

Let me know if there are other places that we print out the numeric nsresult value that we could improve.

Comment 4

[Andrew McCreight [:mccr8]]

I have no idea, sorry.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0ab13abbe9f
Show symbolic nsresult name in NS_ENSURE_SUCCESS warning. r=mccr8

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/a0ab13abbe9f