1265076 - ArrayBufferInputStream violates readSegments contract

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Tom Tromey :tromey]

While working on bug 1244227 I ran into a curious situation where
the network throttling code would sometimes end up sending the wrong
data to the child process.

After much debugging I found out that there is a bug in ArrayBufferInputStream:

https://dxr.mozilla.org/mozilla-central/source/netwerk/base/ArrayBufferInputStream.cpp#114

This always passes 0 as the aToOffset parameter to the nsWriteSegmentFun.
However that is wrong if this goes through the loop more than once.

Comment 1

[Tom Tromey :tromey]

Attachment: MozReview Request: Bug 1265076 - make ArrayBufferInputStream obey readSegments contract; r?mcmanus

Review commit: https://reviewboard.mozilla.org/r/46853/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46853/

Comment 2

[Patrick McManus [:mcmanus]]

Comment on attachment 8741936 [details]
MozReview Request: Bug 1265076 - make ArrayBufferInputStream obey readSegments contract; r?mcmanus

https://reviewboard.mozilla.org/r/46853/#review44007

Comment 3

[Tom Tromey :tromey]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cde30b676e44

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a2a9cec0506a

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a2a9cec0506a