1265104 - There Is No Dragged Text Following in Moving Cursor When Dragging a Link inside the Web Component(Shadow DOM), or inside display: contents;

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Bevis Tseng[:bevis][:btseng](Exited)]

This is a follow-up of the no-dragged-text problem found in bug 1264380 comment 11.

Comment 1

[Andrew Overholt [:overholt]]

William is still working on our Shadow DOM implementation so since were not yet ready to ship that (and AFAIK the spec isn't finalized yet either), I'm going to mark this as backlog.

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Still valid for the ShadowDOM v1 API.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: testcase

try dragging the link.
Interestingly selection the text and then dragging does work.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

The issue seems to be in PresShell::CreateRangePaintInfo where we get null ancestorFrame.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Ah, there is a comment
// XXX deal with ancestorFrame being null due to display:contents
Shadow DOM issue is similar.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Attachment: dnd_display_contents.html

This test doesn't use Shadow DOM, only display: contents;

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1265104, paint dnd'ed content also when it is under non-displayed content (display: contents or ShadowRoot), r=emilio

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

I ended up taking rather simple approach. Common ancestor can already cross shadow boundaries and what not, so flattened parent wouldn't be needed, just some reasonable parent.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

And this code is used in dnd only, so no automated tests :/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5e2e0d4eb05
paint dnd'ed content also when it is under non-displayed content (display: contents or ShadowRoot), r=emilio

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/e5e2e0d4eb05