1265110 - Make switchToTab2, visit and searchWithEngine address bar autocomplete rows localizable

Status: RESOLVED INVALID

(Firefox :: Address Bar, defect)

Description

[Stefan Plewako [:stef]]

After recent changes, bug 1181078, https://hg.mozilla.org/mozilla-central/diff/061165ac1ff9/toolkit/locales/en-US/chrome/global/autocomplete.properties I no longer see a reasonable workaround for hardcoded url and separator placement. Please make them localizable.

(switchToTab2 has also very misleading l10n comment)

Comment 1

[Drew Willcoxon :adw]

I don't understand this bug at all.  All three strings are localizable.  What do you mean by "hardcoded url and separator placement"?  How in the world is switchToTab2's localization note misleading?

Comment 2

[Stefan Plewako [:stef]]

(In reply to Drew Willcoxon :adw from comment #1)
> I don't understand this bug at all.  All three strings are localizable.

You should read read bug reports more carefully probably. Strings are (and I didn't write they aren't), url and separator position is not.

> What do you mean by "hardcoded url and separator placement"?

Open changed address bar and for example type domain name to see how strings in autocomplete rows look (hardocded url hardocded space hardcoded separator hardcoded space localizable string)

> How in the world is switchToTab2's localization note misleading?

From https://hg.mozilla.org/mozilla-central/diff/061165ac1ff9/toolkit/locales/en-US/chrome/global/autocomplete.properties
> -switchToTab = Switch to tab

> +# LOCALIZATION NOTE (switchToTab2): This is the same as the older switchToTab
> +# string that it's replacing, except it uses title case, so "Switch" and "Tab"
> +# are capitalized.
> +switchToTab2 = Switch to Tab

switchToTab2 is not the same as switchToTab at all (ignoring the title case) - it is used differently in different place, context is different.

Comment 3

[Drew Willcoxon :adw]

You should write bug reports more carefully.  "switchToTab2, visit and searchWithEngine address bar autocomplete rows" in the summary doesn't make any sense.  They aren't rows.  So one has to guess at what you mean.

The positions of the URL, separator, title, and switch-to-tab text relative to each other aren't meant to be localizable.  Nor need they be.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Localization in general is not supposed to influence the functionality. For example you can't decide it's better to have url before the title for your locale, or that switch to tab is better as a prefix than a suffix. The confine is subtle, but there is one.
Those are functional decisions influenced by user experience decisions about how we want our users to consume information. Localization has nothing to do with that, since this order is not supposed to be grammatically correct in this case.

(also, please be respectful of others in bugzilla)