1265249 - Mouse cursor only shows part of the dragged selection when it contains multiple ranges

Status: VERIFIED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, defect, P4)

Description

[Mats Palmgren (inactive)]

Attachment: testcase

STR: see testcase

Bug occurs in Firefox 45 (and Nightly) on Linux64.

Comment 1

[Mats Palmgren (inactive)]

My first guess would be that the bug is in PresShell::RenderSelection or related functions:
http://mxr.mozilla.org/mozilla-central/source/layout/base/nsPresShell.cpp?rev=b3ff29311975#5048
Investigating what the display lists looks like there is probably a good first step.
(It looks like there are already DEBUG code there for that purpose.)

Comment 2

[Mats Palmgren (inactive)]

Attachment: testcase 2

A similar test using blocks instead of a table gives a slightly different
result.  Now I see the A's and the B's but not the C's.

It looks like the offset for the later ranges are off so that they
render outside the clip rect.

Comment 3

[Thomas Lange]

I do not know if this is related, but dragging text shows even an icon here.

Reported here: https://bugzilla.mozilla.org/show_bug.cgi?id=1265254

Comment 4

[Andrew Overholt [:overholt]]

I see this on Windows with nightly, too.

Is this a regression?

Comment 5

[Mats Palmgren (inactive)]

Dunno, I didn't test versions <45.

Comment 6

[Andrew Overholt [:overholt]]

QA, can you determine of this is a regression?

Comment 7

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=4e5bfc7ba963&tochange=6cc38353cfa4

Regressed by: Bug 1064056

Comment 8

[Andrew Overholt [:overholt]]

Thanks for the regression window!

Jonathan, what do you think? Bug 1064056 landed over 18 months ago so it's probably not possible/easy to back out now ;)

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

Andrew, do we care about this for 48?

Comment 10

[Andrew Overholt [:overholt]]

I somehow never needinfo'd jwatt.

(In reply to James Willcox (:snorp) ([e-mail]) from comment #9)
> Andrew, do we care about this for 48?

I imagine that we've lived with this for this long that we shouldn't hold 48 for it.

Comment 11

[Jonathan Watt [:jwatt]]

Attachment: patch

Specifically this regression was caused by this chunk:

https://hg.mozilla.org/integration/mozilla-inbound/rev/125aa9f4bd3d#l2.31

Previously we were using AutoPushTranslation which would reset to initialTM then apply a translation during each loop, whereas after the patch we are now incorrectly accumulating transforms into initialTM each loop.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/07322a610cf8
Fix painting of drag selections that contain multiple ranges. r=Bas

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/07322a610cf8

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Bas could you fill the uplift request to beta as it is affected? Thanks
Jonathan is AFK until October
thanks

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Too late for 48 anyway

Comment 16

[Bas Schouten (:bas.schouten)]

(In reply to Sylvestre Ledru [:sylvestre] from comment #15)
> Too late for 48 anyway

Woops.. do you still want this uplifted anywhere?

Comment 17

[Bas Schouten (:bas.schouten)]

(In reply to Bas Schouten (:bas.schouten) from comment #16)
> (In reply to Sylvestre Ledru [:sylvestre] from comment #15)
> > Too late for 48 anyway
> 
> Woops.. do you still want this uplifted anywhere?

(i.e. 49)

Comment 18

[David Bolter [:davidb] (NeedInfo me for attention)]

Yes please request uplift to 49 thanks.

Comment 19

[Bas Schouten (:bas.schouten)]

Comment on attachment 8763923 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: 1064056
[User impact if declined]: Incorrect display of selected range
[Describe test coverage new/current, TreeHerder]: Nightly & Aurora
[Risks and why]: Very low, corrects transform
[String/UUID change made/needed]: None

Comment 20

[Gerry Chang [:gchang]]

Comment on attachment 8763923 [details] [diff] [review]
patch

Review of attachment 8763923 [details] [diff] [review]:
-----------------------------------------------------------------

This patch fixes a regression. Take it in 49 beta.

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/65ca5fd58d1e

Comment 22

[Cornel Ionce [:noni] [Hubs QA]]

Reproduced the initial issue with the attached testcases on Windows 10 x64 using Fx 48.0.2.

Confirming that the text selection is properly displayed while dragged on Windows 10x64, Ubuntu 12.04 x86 and Mac OS X 10.11.6 using:
* Firefox 49.0b10, build ID 20160902105049 
* Latest 50.0a2 Aurora, build ID 20160905004005.