Closed Bug 1265305 Opened 9 years ago Closed 9 years ago

[TV] Tab sync list create clones when pressed enter

Categories

(Firefox OS Graveyard :: Gaia::TV, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.6+, b2g-v2.6 fixed, b2g-master fixed)

Status:
VERIFIED FIXED
Project Flags:
blocking-b2g 2.6+
Tracking Flags:
Tracking Status
b2g-v2.6 --- fixed
b2g-master --- fixed

People

(Reporter: twen, Assigned: danhuang)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(2 files)

[gaia] danhuang1202:bug_1265305_sync_tab_list_not_expand_correctly > mozilla-b2g:master
46 bytes, text/x-github-pull-request
yifan
: review+
jocheng
: approval-gaia-v2.6+
Details | Review
[gaia] danhuang1202:v2.6 > mozilla-b2g:v2.6
46 bytes, text/x-github-pull-request
Details | Review
[Test Steps] Prereq: Fx account signed in with synced tabs 1. Tap device name to open synced tab list 2. Repeat 1. many times [Expected result] No new tabs added [Actual result] Dup tabs added to list
blocking-b2g: --- → 2.6?
Whiteboard: [ft:conndevices]
Assignee: nobody → dhuang
blocking-b2g: 2.6? → 2.6+
Comment on attachment 8744218 [details] [review] [gaia] danhuang1202:bug_1265305_sync_tab_list_not_expand_correctly > mozilla-b2g:master Hi Sean, Please help review this patch! This patch would check if device sync tab list already exist before create one. Thanks.
Attachment #8744218 - Flags: review?(selee)
Comment on attachment 8744218 [details] [review] [gaia] danhuang1202:bug_1265305_sync_tab_list_not_expand_correctly > mozilla-b2g:master Hi Yifan, Could you help to review this patch? Thank you!
Attachment #8744218 - Flags: review?(selee) → review?(yliao)
Attachment #8744218 - Flags: review?(yliao) → review+
Blocks: TV_Testing_2.6
Merge in master: https://github.com/mozilla-b2g/gaia/commit/da1757742f38f48783253475b96fb1c481275ece
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8744218 [details] [review] [gaia] danhuang1202:bug_1265305_sync_tab_list_not_expand_correctly > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #):bug 1239346 [User impact] if declined: sync tab list would work incorrectly [Testing completed]: Yes [Risk to taking this patch] (and alternatives if risky): None [String changes made]: None
Attachment #8744218 - Flags: approval-gaia-v2.6?
Comment on attachment 8744218 [details] [review] [gaia] danhuang1202:bug_1265305_sync_tab_list_not_expand_correctly > mozilla-b2g:master Approve for TV 2.6
Attachment #8744218 - Flags: approval-gaia-v2.6? → approval-gaia-v2.6+
Verified fixed on master and v2.6, no clones.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: