Closed
Bug 1265447
Opened 8 years ago
Closed 8 years ago
Silence startup JavaScript strict warning in resource://gre/modules/addons/XPIProvider.jsm
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
Attachments
(1 file)
1.10 KB,
patch
|
rhelmer
:
review+
|
Details | Diff | Splinter Review |
When starting up I get the following noise in the console: JavaScript strict warning: resource://gre/modules/addons/XPIProvider.jsm, line 7373: SyntaxError: test for equality (==) mistyped as assignment (=)? due to the commit for bug 1005193.
![]() |
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8742412 -
Flags: review?(jhofmann)
Comment 2•8 years ago
|
||
Comment on attachment 8742412 [details] [diff] [review] patch Oh, thanks for fixing that. If that's a strict warning we should maybe have an ESLint rule for it! This is r+ from me but I can't review here and so I'll relay to rhelmer. Thanks!
Attachment #8742412 -
Flags: review?(jhofmann) → review?(rhelmer)
Updated•8 years ago
|
Attachment #8742412 -
Flags: review?(rhelmer) → review+
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2da0c84c972a
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•