Closed Bug 1265447 Opened 4 years ago Closed 4 years ago

Silence startup JavaScript strict warning in resource://gre/modules/addons/XPIProvider.jsm

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(1 file)

When starting up I get the following noise in the console:

JavaScript strict warning: resource://gre/modules/addons/XPIProvider.jsm, line 7373: SyntaxError: test for equality (==) mistyped as assignment (=)?

due to the commit for bug 1005193.
Attached patch patchSplinter Review
Attachment #8742412 - Flags: review?(jhofmann)
Comment on attachment 8742412 [details] [diff] [review]
patch

Oh, thanks for fixing that. If that's a strict warning we should maybe have an ESLint rule for it!

This is r+ from me but I can't review here and so I'll relay to rhelmer.

Thanks!
Attachment #8742412 - Flags: review?(jhofmann) → review?(rhelmer)
Attachment #8742412 - Flags: review?(rhelmer) → review+
https://hg.mozilla.org/mozilla-central/rev/2da0c84c972a
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.