1265541 - cubeb doesn't build with libc++ because of #defining unique_ptr

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[(no longer active)]

0:17.40 In file included from /Users/ehsan/moz/src/media/libcubeb/tests/test_resampler.cpp:18:
 0:17.40 In file included from /Users/ehsan/Downloads/clang+llvm-3.7.0-x86_64-apple-darwin/bin/../include/c++/v1/iostream:40:
 0:17.40 In file included from /Users/ehsan/Downloads/clang+llvm-3.7.0-x86_64-apple-darwin/bin/../include/c++/v1/istream:163:
 0:17.40 In file included from /Users/ehsan/Downloads/clang+llvm-3.7.0-x86_64-apple-darwin/bin/../include/c++/v1/ostream:140:
 0:17.40 /Users/ehsan/Downloads/clang+llvm-3.7.0-x86_64-apple-darwin/bin/../include/c++/v1/locale:230:9: error: no template named 'UniquePtr' in namespace 'std::__1'; did you mean simply 'UniquePtr'?
 0:17.40 typedef _VSTD::unique_ptr<__locale_struct, decltype(&freelocale)> __locale_unique_ptr;
 0:17.40         ^~~~~~~
 0:17.40 /Users/ehsan/Downloads/clang+llvm-3.7.0-x86_64-apple-darwin/bin/../include/c++/v1/__config:388:15: note: expanded from macro '_VSTD'
 0:17.40 #define _VSTD std::_LIBCPP_NAMESPACE
 0:17.40               ^
 0:17.40 /Users/ehsan/moz/src/obj-ff-clang-plugin.noindex/dist/include/mozilla/UniquePtr.h:188:7: note: 'UniquePtr' declared here
 0:17.40 class UniquePtr
 0:17.40       ^

Comment 1

[(no longer active)]

Patch submitted upstream: https://github.com/kinetiknz/cubeb/pull/100

Comment 2

[(no longer active)]

Attachment: Make the unique_ptr replacment technique compatible with libc++

Comment 3

[Paul Adenot (:padenot)]

Comment on attachment 8742510 [details] [diff] [review]
Make the unique_ptr replacment technique compatible with libc++

Review of attachment 8742510 [details] [diff] [review]:
-----------------------------------------------------------------

I'll land this today with a cubeb uplift, there are a couple other things we need and are present upstream.

Comment 4

[Paul Adenot (:padenot)]

Pushed as part of https://hg.mozilla.org/integration/mozilla-inbound/rev/2f3a6b7cd4b3

Comment 5

[(no longer active)]

Thanks!