Closed Bug 1265593 Opened 4 years ago Closed 4 years ago

Forward app server keys to Autopush on Android

Categories

(Core :: DOM: Push Notifications, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: Lina, Assigned: Lina)

References

Details

(Whiteboard: btpp-active)

Attachments

(1 file)

Bug 1247685 adds support for restricted subscriptions to the DOM API, via `applicationServerKey`. This bug tracks the work to support them on Android.

Autopush doesn't accept app server keys via the HTTP API yet. We should be able to test this end-to-end once https://github.com/mozilla-services/autopush/pull/443 is staged.
Comment on attachment 8742593 [details]
MozReview Request: Bug 1265593 - Forward app server keys to Autopush on Android. r?nalexander

https://reviewboard.mozilla.org/r/47339/#review44209

This looks fine, assuming that `appServerKey` is never needed past the single subscribe request.
Attachment #8742593 - Flags: review?(nalexander) → review+
(In reply to Nick Alexander :nalexander from comment #2)
> This looks fine, assuming that `appServerKey` is never needed past the
> single subscribe request.

Thanks, Nick! It's not needed at the Autopush level past the subscribe request.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab0326f2b04f
Comment on attachment 8742593 [details]
MozReview Request: Bug 1265593 - Forward app server keys to Autopush on Android. r?nalexander

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47339/diff/1-2/
Nick, I updated the tests. Please take another look if you have time.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=67b06be4aa7a
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca252a2e2171
Forward app server keys to Autopush on Android. r=nalexander
https://hg.mozilla.org/mozilla-central/rev/ca252a2e2171
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.