1265593 - Forward app server keys to Autopush on Android

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, defect)

Description

[Lina Butler [:lina]]

Bug 1247685 adds support for restricted subscriptions to the DOM API, via `applicationServerKey`. This bug tracks the work to support them on Android.

Autopush doesn't accept app server keys via the HTTP API yet. We should be able to test this end-to-end once https://github.com/mozilla-services/autopush/pull/443 is staged.

Comment 1

[Lina Butler [:lina]]

Attachment: MozReview Request: Bug 1265593 - Forward app server keys to Autopush on Android. r?nalexander

Review commit: https://reviewboard.mozilla.org/r/47339/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47339/

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8742593 [details]
MozReview Request: Bug 1265593 - Forward app server keys to Autopush on Android. r?nalexander

https://reviewboard.mozilla.org/r/47339/#review44209

This looks fine, assuming that `appServerKey` is never needed past the single subscribe request.

Comment 3

[Lina Butler [:lina]]

(In reply to Nick Alexander :nalexander from comment #2)
> This looks fine, assuming that `appServerKey` is never needed past the
> single subscribe request.

Thanks, Nick! It's not needed at the Autopush level past the subscribe request.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab0326f2b04f

Comment 4

[Lina Butler [:lina]]

Comment on attachment 8742593 [details]
MozReview Request: Bug 1265593 - Forward app server keys to Autopush on Android. r?nalexander

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47339/diff/1-2/

Comment 5

[Lina Butler [:lina]]

Nick, I updated the tests. Please take another look if you have time.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=67b06be4aa7a

Comment 6

[Nick Alexander :nalexander [he/him]]

https://reviewboard.mozilla.org/r/47339/#review53376

This looks good to me!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca252a2e2171
Forward app server keys to Autopush on Android. r=nalexander

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ca252a2e2171