1265655 - graph/compare by framework isn't working for talos-aws

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

I have a data now that was posted with framework: 'talos-aws', and it is getting mixed up with the 'talos' results.

for example, take a look at:
https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=e93ebef962dd&newProject=try&newRevision=0ad2d3cc82086352841c758010ff08f0e73714fa&framework=7&showOnlyImportant=0

and you can see the try pushes, there are 12 jobs each, 6 are talos and 6 are talos-aws (you can look at the machine name to see what ran what)

I suspect there is a small tweak needed to fix this.

Comment 1

[William Lachance (:wlach)]

Eugh, what a can of worms this AWS thing turns out to be. :) We're not filtering the performance data we're returning in this view (or any view for that matter) by framework. I'll do up some patches.

Comment 2

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1265655 > mozilla:master

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

thanks wlach!

Comment 4

[William Lachance (:wlach)]

Comment on attachment 8742861 [details] [review]
[treeherder] wlach:1265655 > mozilla:master

So I am increasingly thinking that I made a major mistake by not incorporating the framework id when generating signature hashes (see bug 1265709) but that's going to be a bit of effort to fix. For now, here's some code which works around this bug by adding a "framework" parameter to the performance data endpoint (and using it in the frontend).

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8742861 [details] [review]
[treeherder] wlach:1265655 > mozilla:master

this looks good, the e10s stuff is hardcoded to talos framework, I think that is fine.

Comment 6

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla/treeherder/commit/708671c7b36fb790d62eeb73d1b520524477c3c5

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/0e8847027fde7c8f257b5c4be60425910573ff1c
Bug 1265655 - Filter by framework when getting performance data