Closed
Bug 1265710
Opened 9 years ago
Closed 8 years ago
Consider using "Apple Touch Icons" in app UI (Instead of Favicons)
Categories
(Firefox for Android Graveyard :: Favicon Handling, defect)
Tracking
(firefox49 verified)
VERIFIED
FIXED
Firefox 49
Tracking | Status | |
---|---|---|
firefox49 | --- | verified |
People
(Reporter: sebastian, Assigned: sebastian)
References
Details
Attachments
(4 files)
Some sites do only have ugly 16x16 favicons and nice apple touch icons. Facebook and YouTube for example.
So far we only use the touch icons for home screen shortcuts. Using them in the app would improve our icon quality significantly.
Assignee | ||
Updated•9 years ago
|
Blocks: site-icons
Assignee | ||
Comment 1•9 years ago
|
||
Comment 2•9 years ago
|
||
Makes sense to me.
Though, we should start being aware of all the different icons we'll be getting for popular sites. I think if we DON'T have it covered in Tippy Top (bug 1263707), then we should use these icons.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•9 years ago
|
||
Before we can do that we need to fix our current favicon issues. Especially bug 1269821 and bug 1271634. Fixing those bugs might require restructuring the way we store and link favicons.
Assignee: s.kaspari → nobody
Status: ASSIGNED → NEW
Assignee | ||
Comment 4•9 years ago
|
||
While working on bug 1264901 I found a simpler way of using those icons. I'll prepare a patch.
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•9 years ago
|
||
Assignee | ||
Comment 6•9 years ago
|
||
Originally I wanted to keep them as a separate type of icon and store them separately.
But this is much simpler and a big improvement. We wanted to treat touch icons as
better favicons anyways and making them go through the same pipeline gives us exactly
that.
Review commit: https://reviewboard.mozilla.org/r/57630/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57630/
Attachment #8759762 -
Flags: review?(ahunt)
Comment 7•9 years ago
|
||
Comment on attachment 8759762 [details]
Bug 1265710 - Treat apple-touch-icons like favicons and use them in the app UI.
https://reviewboard.mozilla.org/r/57630/#review54462
Attachment #8759762 -
Flags: review?(ahunt) → review+
Pushed by s.kaspari@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3978ffc8e928
Treat apple-touch-icons like favicons and use them in the app UI. r=ahunt
Comment 9•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment 10•8 years ago
|
||
Verified as fixed in build 49.0a1 2016-06-06;
Device: LG G4 (Android 5.1).
Updated•8 years ago
|
Status: RESOLVED → VERIFIED
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•