Consider using "Apple Touch Icons" in app UI (Instead of Favicons)

VERIFIED FIXED in Firefox 49

Status

()

Firefox for Android
Favicon Handling
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: sebastian, Assigned: sebastian)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 49
All
Android
Points:
---

Firefox Tracking Flags

(firefox49 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments)

(Assignee)

Description

2 years ago
Some sites do only have ugly 16x16 favicons and nice apple touch icons. Facebook and YouTube for example.

So far we only use the touch icons for home screen shortcuts. Using them in the app would improve our icon quality significantly.
(Assignee)

Updated

2 years ago
Blocks: 1265712
(Assignee)

Comment 1

2 years ago
Created attachment 8742820 [details]
icons_facebook_youtube.png
Makes sense to me. 

Though, we should start being aware of all the different icons we'll be getting for popular sites. I think if we DON'T have it covered in Tippy Top (bug 1263707), then we should use these icons.
(Assignee)

Updated

2 years ago
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
(Assignee)

Comment 3

2 years ago
Before we can do that we need to fix our current favicon issues. Especially bug 1269821 and bug 1271634. Fixing those bugs might require restructuring the way we store and link favicons.
Assignee: s.kaspari → nobody
Status: ASSIGNED → NEW
(Assignee)

Comment 4

2 years ago
While working on bug 1264901 I found a simpler way of using those icons. I'll prepare a patch.
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
(Assignee)

Comment 5

2 years ago
Created attachment 8759753 [details]
touch-icons-in-ui.png
(Assignee)

Comment 6

2 years ago
Created attachment 8759762 [details]
Bug 1265710 - Treat apple-touch-icons like favicons and use them in the app UI.

Originally I wanted to keep them as a separate type of icon and store them separately.
But this is much simpler and a big improvement. We wanted to treat touch icons as
better favicons anyways and making them go through the same pipeline gives us exactly
that.

Review commit: https://reviewboard.mozilla.org/r/57630/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57630/
Attachment #8759762 - Flags: review?(ahunt)

Comment 7

2 years ago
Comment on attachment 8759762 [details]
Bug 1265710 - Treat apple-touch-icons like favicons and use them in the app UI.

https://reviewboard.mozilla.org/r/57630/#review54462
Attachment #8759762 - Flags: review?(ahunt) → review+

Comment 8

2 years ago
Pushed by s.kaspari@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3978ffc8e928
Treat apple-touch-icons like favicons and use them in the app UI. r=ahunt

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3978ffc8e928
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Created attachment 8760289 [details]
Screenshot_2016-06-06-17-36-22.png

Verified as fixed in build 49.0a1 2016-06-06;
Device: LG G4 (Android 5.1).
Status: RESOLVED → VERIFIED
status-firefox49: fixed → verified
You need to log in before you can comment on or make changes to this bug.