Don't try to emit notification events if the extension has been unloaded

RESOLVED FIXED in Firefox 48

Status

P2
normal
RESOLVED FIXED
3 years ago
5 months ago

People

(Reporter: bsilverberg, Assigned: bsilverberg)

Tracking

unspecified
mozilla49
Bug Flags:
blocking-webextensions +

Firefox Tracking Flags

(firefox47 wontfix, firefox48 fixed, firefox49 fixed)

Details

(Whiteboard: triaged)

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
This is a follow-up from bug 1264818, which is for an intermittent with test_ext_notifications.html.

This fix may or may not help with that intermittent, but it should be implemented regardless, so I am opening a separate bug for it.
(Assignee)

Updated

3 years ago
Assignee: nobody → bob.silverberg
Status: NEW → ASSIGNED
Iteration: --- → 48.3 - Apr 25
(Assignee)

Comment 1

3 years ago
Created attachment 8742822 [details]
MozReview Request: Bug 1265716 - Don't try to emit notification events if the extension has been unloaded, r?aswan

Review commit: https://reviewboard.mozilla.org/r/47463/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47463/
Attachment #8742822 - Flags: review?(aswan)
(Assignee)

Comment 2

3 years ago
Andrew, this is the exact same patch as was attached to bug 1264818, but it needs an official r? from you in order to land.

Comment 3

3 years ago
Comment on attachment 8742822 [details]
MozReview Request: Bug 1265716 - Don't try to emit notification events if the extension has been unloaded, r?aswan

https://reviewboard.mozilla.org/r/47463/#review44223
Attachment #8742822 - Flags: review?(aswan) → review+

Updated

3 years ago
Flags: blocking-webextensions+
Priority: -- → P2
Whiteboard: triaged
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e51ba816be5f
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
(Assignee)

Comment 7

3 years ago
Comment on attachment 8742822 [details]
MozReview Request: Bug 1265716 - Don't try to emit notification events if the extension has been unloaded, r?aswan

Approval Request Comment
[Feature/regressing bug #]: Bug 1276706 - notifications.clear not working
[User impact if declined]: This is required to uplift Bug 1265797 which fixes a bug in the WebExtensions notifications API which is meant to be feature-complete in 48. Users of the API could easily hit this bug.
[Describe test coverage new/current, TreeHerder]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b92fec992103
[Risks and why]: This is a very simple change, isolated to toolkit/components/extensions/ext-notifications.js so can be considered to be low risk.
[String/UUID change made/needed]: none

Note that this is one of three bugs that need to be uplifted to address the problem. The others are bug 1265797 and bug 1275363.
Attachment #8742822 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

3 years ago
status-firefox47: --- → wontfix
status-firefox48: --- → affected
Comment on attachment 8742822 [details]
MozReview Request: Bug 1265716 - Don't try to emit notification events if the extension has been unloaded, r?aswan

Improve WebExtension, taking it
Attachment #8742822 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 9

3 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/8f354a50cdf2
status-firefox48: affected → fixed

Updated

5 months ago
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.