Closed
Bug 1265716
Opened 10 years ago
Closed 10 years ago
Don't try to emit notification events if the extension has been unloaded
Categories
(WebExtensions :: Untriaged, defect, P2)
WebExtensions
Untriaged
Tracking
(firefox47 wontfix, firefox48 fixed, firefox49 fixed)
People
(Reporter: bsilverberg, Assigned: bsilverberg)
References
Details
(Whiteboard: triaged)
Attachments
(1 file)
|
58 bytes,
text/x-review-board-request
|
aswan
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details |
This is a follow-up from bug 1264818, which is for an intermittent with test_ext_notifications.html.
This fix may or may not help with that intermittent, but it should be implemented regardless, so I am opening a separate bug for it.
| Assignee | ||
Updated•10 years ago
|
Assignee: nobody → bob.silverberg
Status: NEW → ASSIGNED
Iteration: --- → 48.3 - Apr 25
| Assignee | ||
Comment 1•10 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/47463/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47463/
Attachment #8742822 -
Flags: review?(aswan)
| Assignee | ||
Comment 2•10 years ago
|
||
Andrew, this is the exact same patch as was attached to bug 1264818, but it needs an official r? from you in order to land.
Comment 3•10 years ago
|
||
Comment on attachment 8742822 [details]
MozReview Request: Bug 1265716 - Don't try to emit notification events if the extension has been unloaded, r?aswan
https://reviewboard.mozilla.org/r/47463/#review44223
Attachment #8742822 -
Flags: review?(aswan) → review+
| Assignee | ||
Comment 4•10 years ago
|
||
Updated•10 years ago
|
Flags: blocking-webextensions+
Priority: -- → P2
Whiteboard: triaged
| Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Comment 6•10 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
| Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8742822 [details]
MozReview Request: Bug 1265716 - Don't try to emit notification events if the extension has been unloaded, r?aswan
Approval Request Comment
[Feature/regressing bug #]: Bug 1276706 - notifications.clear not working
[User impact if declined]: This is required to uplift Bug 1265797 which fixes a bug in the WebExtensions notifications API which is meant to be feature-complete in 48. Users of the API could easily hit this bug.
[Describe test coverage new/current, TreeHerder]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b92fec992103
[Risks and why]: This is a very simple change, isolated to toolkit/components/extensions/ext-notifications.js so can be considered to be low risk.
[String/UUID change made/needed]: none
Note that this is one of three bugs that need to be uplifted to address the problem. The others are bug 1265797 and bug 1275363.
Attachment #8742822 -
Flags: approval-mozilla-aurora?
| Assignee | ||
Updated•10 years ago
|
status-firefox47:
--- → wontfix
status-firefox48:
--- → affected
Comment 8•10 years ago
|
||
Comment on attachment 8742822 [details]
MozReview Request: Bug 1265716 - Don't try to emit notification events if the extension has been unloaded, r?aswan
Improve WebExtension, taking it
Attachment #8742822 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 9•10 years ago
|
||
| bugherder uplift | ||
Updated•8 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•