Closed Bug 1265830 Opened 4 years ago Closed 3 years ago

don't use nsIDOMCSSRule

Categories

(DevTools :: Framework, enhancement, P1)

Product:
DevTools
Component:
Framework
Type:
enhancement

Tracking

(firefox50 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 50
Iteration:
50.1 - Jun 20
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: tromey, Assigned: tromey)

References

Details

(Whiteboard: [devtools-html])

Attachments

(1 file)

Bug 1265830 - remove uses of nsIDOMCSSRule from devtools;
58 bytes, text/x-review-board-request
bgrins
: review+
Details 
Stop using nsIDOMCSSRule, for the devtools de-chrome-ification project.

This seems to just be used for the constant Ci.nsIDOMCSSRule.KEYFRAME_RULE.
Perhaps CSSRule.KEYFRAME_RULE can be used instead; or perhaps this can
be supplied by the front, like ELEMENT_STYLE seems to be.
Flags: qe-verify-
Priority: -- → P2
Priority: P2 → P1
Assignee: nobody → ttromey
Status: NEW → ASSIGNED
Iteration: --- → 50.1
Attachment #8763189 - Flags: review?(pbrosset) → review?(bgrinstead)
Comment on attachment 8763189 [details]
Bug 1265830 - remove uses of nsIDOMCSSRule from devtools;

https://reviewboard.mozilla.org/r/59490/#review56750

Nice
Attachment #8763189 - Flags: review?(bgrinstead) → review+
Please update commit message with new reviewer before landing
Comment on attachment 8763189 [details]
Bug 1265830 - remove uses of nsIDOMCSSRule from devtools;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59490/diff/1-2/
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/bb9e0276322d
Remove uses of nsIDOMCSSRule from devtools. r=bgrins
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/bb9e0276322d
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.