Closed
Bug 1265830
Opened 8 years ago
Closed 8 years ago
don't use nsIDOMCSSRule
Categories
(DevTools :: Framework, enhancement, P1)
DevTools
Framework
Tracking
(firefox50 fixed)
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: tromey, Assigned: tromey)
References
Details
(Whiteboard: [devtools-html])
Attachments
(1 file)
Stop using nsIDOMCSSRule, for the devtools de-chrome-ification project. This seems to just be used for the constant Ci.nsIDOMCSSRule.KEYFRAME_RULE. Perhaps CSSRule.KEYFRAME_RULE can be used instead; or perhaps this can be supplied by the front, like ELEMENT_STYLE seems to be.
Updated•8 years ago
|
Flags: qe-verify-
Priority: -- → P2
Updated•8 years ago
|
Priority: P2 → P1
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → ttromey
Status: NEW → ASSIGNED
Updated•8 years ago
|
Iteration: --- → 50.1
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/59490/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/59490/
Attachment #8763189 -
Flags: review?(pbrosset)
Assignee | ||
Updated•8 years ago
|
Attachment #8763189 -
Flags: review?(pbrosset) → review?(bgrinstead)
Comment 2•8 years ago
|
||
Comment on attachment 8763189 [details] Bug 1265830 - remove uses of nsIDOMCSSRule from devtools; https://reviewboard.mozilla.org/r/59490/#review56750 Nice
Attachment #8763189 -
Flags: review?(bgrinstead) → review+
Comment 3•8 years ago
|
||
Please update commit message with new reviewer before landing
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8763189 [details] Bug 1265830 - remove uses of nsIDOMCSSRule from devtools; Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59490/diff/1-2/
Assignee | ||
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6bf02662cb12
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/fx-team/rev/bb9e0276322d Remove uses of nsIDOMCSSRule from devtools. r=bgrins
Keywords: checkin-needed
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bb9e0276322d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•