1265840 - remove Services.tm uses

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P1)

Description

[Tom Tromey :tromey]

Remove Services.tm uses for devtools de-chrome-ification project.
See also bug 1265530.
The uses in the inspector seem to be just for setImmediate-like purposes.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

There is DevToolsUtils.executeSoon, which it might make sense to change direct usages of Services.tm into.  DevToolsUtils.executeSoon does currently use Services.tm (outside of workers), but then you'd at least remove redundant code paths and have only one utility function to think about.

Comment 3

[Tom Tromey :tromey]

Yeah, that would be an improvement.
Maybe DevToolsUtils could be split up a bit too.  Also I was thinking maybe the loader could
define "setTimeout" and "setImmediate" just like it does for "console", to let us remove explicit
uses of Timer.jsm.  Though that's probably going to be a different bug.

Comment 4

[Tom Tromey :tromey]

One of the uses of Services.tm would probably better be replaced by setImmediate.

Comment 5

[Tom Tromey :tromey]

Attachment: remove resolveNextTick in favor of DevToolsUtils.waitForTick

MozReview-Commit-ID: DQoXLeXKUn3

This fixes the uses coming from the inspector.

There are some in devtools/shared, but I'm postponing those.
There are some in devtools/server, but we can ignore those.
And finally there are two in devtools/client/debugger, but I assume
that's being handled by debugger.html.

Comment 6

[Tom Tromey :tromey]

Attachment: MozReview Request: Bug 1265840 - remove uses of Services.tm from inspector; r?pbro

Review commit: https://reviewboard.mozilla.org/r/48749/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/48749/

Comment 7

[Patrick Brosset <:pbro>]

Comment on attachment 8744976 [details]
MozReview Request: Bug 1265840 - remove uses of Services.tm from inspector; r?pbro

https://reviewboard.mozilla.org/r/48749/#review45589

Looking good, thanks!

Comment 8

[Tom Tromey :tromey]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab531ef7f71a

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/f82ed4256233

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f82ed4256233