Closed
Bug 1265893
Opened 8 years ago
Closed 8 years ago
Enable rust for linux32 official builds
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: rillian, Assigned: rillian)
References
Details
Attachments
(2 files)
Time to turn this on for 32 bit linux.
Assignee | ||
Comment 1•8 years ago
|
||
This is the same repack of the upstream 1.8.0 stable build for x86_64-unknown-linux-gnu hosts plus the i686 and x86_64 std libraries used for the linux64 builds. Review commit: https://reviewboard.mozilla.org/r/47517/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/47517/
Attachment #8743014 -
Flags: review?(mshal)
Attachment #8743015 -
Flags: review?(mshal)
Assignee | ||
Comment 2•8 years ago
|
||
Pass --enable-rust for official Firefox builds on 32-bit linux. This enables it for all channels, just like other platforms. Review commit: https://reviewboard.mozilla.org/r/47515/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/47515/
Assignee | ||
Comment 3•8 years ago
|
||
Green on try. https://treeherder.mozilla.org/#/jobs?repo=try&revision=c75ab5c227ac
Updated•8 years ago
|
Attachment #8743014 -
Flags: review?(mshal) → review+
Updated•8 years ago
|
Attachment #8743015 -
Flags: review?(mshal) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/8222fad19eab https://hg.mozilla.org/integration/mozilla-inbound/rev/be6c4979ddaf
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8222fad19eab https://hg.mozilla.org/mozilla-central/rev/be6c4979ddaf
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment 6•8 years ago
|
||
as a note, this increased the installer size of linux32 builds: https://treeherder.mozilla.org/perf.html#/alerts?id=954
Comment 7•8 years ago
|
||
I just talked with :acrichto, and he mentioned that we should be able to enable LTO for rust when building the static lib and significantly shrink the size of the resulting binary.
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•