1265893 - Enable rust for linux32 official builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ralph Giles (:rillian)]

Time to turn this on for 32 bit linux.

Comment 1

[Ralph Giles (:rillian)]

Attachment: MozReview Request: Bug 1265893 - Import tooltool rust 1.8 on linux32. r?mshal

This is the same repack of the upstream 1.8.0 stable build
for x86_64-unknown-linux-gnu hosts plus the i686 and
x86_64 std libraries used for the linux64 builds.

Review commit: https://reviewboard.mozilla.org/r/47517/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47517/

Comment 2

[Ralph Giles (:rillian)]

Attachment: MozReview Request: Bug 1265893 - Enable rust for linux32 official builds. r?mshal

Pass --enable-rust for official Firefox builds on 32-bit
linux. This enables it for all channels, just like other
platforms.

Review commit: https://reviewboard.mozilla.org/r/47515/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47515/

Comment 3

[Ralph Giles (:rillian)]

Green on try. https://treeherder.mozilla.org/#/jobs?repo=try&revision=c75ab5c227ac

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8222fad19eab
https://hg.mozilla.org/integration/mozilla-inbound/rev/be6c4979ddaf

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8222fad19eab
https://hg.mozilla.org/mozilla-central/rev/be6c4979ddaf

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

as a note, this increased the installer size of linux32 builds:
https://treeherder.mozilla.org/perf.html#/alerts?id=954

Comment 7

[Lars Bergstrom (:larsberg)]

I just talked with :acrichto, and he mentioned that we should be able to enable LTO for rust when building the static lib and significantly shrink the size of the resulting binary.