1266052 - crash in nsMsgGroupView::GetCellProperties

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Wayne Mery (:wsmwk)]

#18 crash for 45.0 

This would appear to be a regression. First appears in crash-stats with build 20150920030322 bp-bebf18c5-c7b2-4d45-bf58-a58342160125.
 0 	xul.dll	nsMsgGroupView::GetCellProperties(int, nsITreeColumn*, nsAString_internal&)	c:/builds/moz2_slave/tb-c-cen-w64-ntly-000000000000/build/mailnews/base/src/nsMsgGroupView.cpp:752
1 	xul.dll	nsTreeBodyFrame::PaintCell(int, nsTreeColumn*, nsRect const&, nsPresContext*, nsRenderingContext&, nsRect const&, int&, nsPoint)	layout/xul/tree/nsTreeBodyFrame.cpp
2 	xul.dll	nsTreeBodyFrame::PaintRow(int, nsRect const&, nsPresContext*, nsRenderingContext&, nsRect const&, nsPoint)	layout/xul/tree/nsTreeBodyFrame.cpp
3 	xul.dll	nsTreeBodyFrame::PaintTreeBody(nsRenderingContext&, nsRect const&, nsPoint)	layout/xul/tree/nsTreeBodyFrame.cpp
4 	xul.dll	nsDisplayTreeBody::Paint(nsDisplayListBuilder*, nsRenderingContext*)	layout/xul/tree/nsTreeBodyFrame.cpp
5 	xul.dll	mozilla::FrameLayerBuilder::PaintItems(nsTArray<mozilla::FrameLayerBuilder::ClippedDisplayItem>&, mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits> const&, gfxContext*, nsRenderingContext*, nsDisplayListBuilder*, nsPresContext*, mozilla::gfx::IntPointTyped<mozilla::gfx::UnknownUnits> const&, float, float, int)	layout/base/FrameLayerBuilder.cpp 

One user of 45.0a2 (probably @oracle) bp-c95c5da3-d019-47c9-8ed1-2f5fc2160120 writes "doing a quick search... ".  Another crash of his/hers is bp-a95a8d90-e6c6-43e8-9585-64e472160120

Comment 1

[alta88]

Attachment: groupThread.patch

this might fix it.

Comment 2

[Kent James (:rkent)]

Comment on attachment 8743272 [details] [diff] [review]
groupThread.patch

Review of attachment 8743272 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 3

[alta88]

Comment on attachment 8743272 [details] [diff] [review]
groupThread.patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on c-c, etc.): 
Risk to taking this patch (and alternatives if risky):

Comment 4

[alta88]

(In reply to alta88 from comment #3)
> Comment on attachment 8743272 [details] [diff] [review]
> groupThread.patch
> 
> [Approval Request Comment]

no risk patch for a crasher.

Comment 5

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/1be3e2701e24bab7ddc7e61e8ef6dcf5aba26671
Bug 1266052 - Crash in nsMsgGroupView::GetCellProperties. r=rkent

Comment 6

[Kent James (:rkent)]

Comment on attachment 8743272 [details] [diff] [review]
groupThread.patch

http://hg.mozilla.org/releases/comm-esr45/rev/b1331bff1348

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 8743272 [details] [diff] [review]
groupThread.patch

[Triage Comment]
This should be landed on Aurora TB 47 for the next 47 beta.

Comment 8

[Jorg K (CEST = GMT+2)]

Aurora (TB 47):
https://hg.mozilla.org/releases/comm-aurora/rev/b300d9fbca1a