1266178 - Expose ServiceWorkerClient.frameType of "none" when document does not have a window

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

While working on the test for bug 1265795 I ran into this assert:

  MOZ_ASSERT(outerWindow);

At:

  https://dxr.mozilla.org/mozilla-central/source/dom/workers/ServiceWorkerClient.cpp?from=ServiceWorkerClient.cpp#67

I'm going to be closing some of the cases which allow this, but I think there is always the risk someone will get a client just as the user closes it.  We should gracefully handle this by returning the default "none" frame type.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Make ServiceWorkerClient not assert if the document doesn't have an outer window. r=ehsan

This also sets a default frame type which should improve the safety of the code a bit.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/987e2c82c04f

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/987e2c82c04f