1266182 - Refactor SimpleHelperUI and HomeScreenPrompt to remove duplication

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Andrzej Hunt :ahunt]

Bug 1246238 adds a SimpleHelperUI, with plenty of duplicate code from HomeScreenPrompt. We should extract the common code, and maybe extract common layout elements (e.g. we could share the container from the layout file, since that's also required for the shared animations - and then <include> specific layouts for the subclasses).

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Thanks for filing this!

HomeScreenPrompt is already inspired by TabQueuePrompt partially and I was wondering if it makes sense to create a base implementation for that. Seems like it does. :)

Comment 2

[Andrzej Hunt :ahunt]

Some more comments from sebastian in https://bugzilla.mozilla.org/show_bug.cgi?id=1246238#c7:

(Copying them here since that bug is just about to close)

> Maybe it makes more sense to create a "base" activity that creates the basic
> layout, handles the animations, touching outside, clicking the close button,
> has helpful methods and the different prompts extend from it, inject their
> own layout in the shell provided by the base class and then do whatever they
> want to do. What's nice about this is that it is more flexible and you can
> handle the success/rejection case in the prompt (if possible) and do not
> necessarily need to return something and this is again handled somewhere
> else.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

There's also:
 * bug 1232706: "Add to Homescreen" 
 * bug 1217174: helper UI for send-to-device

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

A good reason to remove the duplication: the behavior for whatever prompt I was seeing in bug 1268576 is different than the other prompts. If were to fix it, we want to make sure it doesn't affect the other implementation.

Comment 5

[Andrzej Hunt :ahunt]

Dropping this for now. We should do this before adding any new prompts, however due to the number of prompts it's also hard to guarantee no regressions, hence there's not much value unless we're adding more prompts.

Comment 6

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.