Re-land the useful renaming parts of bug 1208344

RESOLVED FIXED in Firefox 48

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(2 attachments)

Filing this bug on re-landing the still-useful parts of bug 1208344, after its patch-stack was backed out (to change the overall strategy) in bug 1262049.
Assignee: nobody → dholbert
In particular, I'll be re-landing this patch to rename the MapSinglePropertyInto args:
 https://hg.mozilla.org/mozilla-central/rev/b3a36d79154f
...and this "Can't map into a logical property" MOZ_ASSERT that I added to MapSinglePropertyInto:
 https://hg.mozilla.org/mozilla-central/rev/c1e9d6224c5a#l1.19
(but not the rest of c1e9d6224c5a's MapSinglePropertyInto refactoring)
Created attachment 8743990 [details] [diff] [review]
part 1: Rename MapSinglePropertyInto() args, to make src-vs-target distinctions clearer.

Here's the first part (re-landing an unbitrotted version of mozilla-central commit b3a36d79154f).
Created attachment 8743991 [details] [diff] [review]
part 2: Add assertion to verify that MapSinglePropertyInto() isn't called with a logical target-property

...and here's the second part (adding back the assertion from mozilla-central changeset c1e9d6224c5a).

Carrying forward r=heycam, since these are substantially the same as the old versions (verified locally by comparing new vs. old patches in 'meld' merge tool).
Status: NEW → ASSIGNED
status-firefox48: affected → ---

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/91b6739888bf
https://hg.mozilla.org/mozilla-central/rev/97a73074dc7c
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.