1266256 - Don't try to create null URLs in _isMinifiedURL

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Eric Rahm [:erahm]]

Avoid passing null to the URL constructor, it causes warnings on debug builds.

Comment 1

[Eric Rahm [:erahm]]

Attachment: Don't try to create null URLs in _isMinifiedURL

Comment 2

[Eric Rahm [:erahm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c499448bbedc

Comment 3

[Eddy Bruel [:ejpbruel]]

Comment on attachment 8743620 [details] [diff] [review]
Don't try to create null URLs in _isMinifiedURL

Review of attachment 8743620 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Would be nice to add a comment explaining why you added this check.

Comment 4

[Eric Rahm [:erahm]]

(In reply to Eddy Bruel [:ejpbruel] from comment #3)
> Comment on attachment 8743620 [details] [diff] [review]
> Don't try to create null URLs in _isMinifiedURL
> 
> Review of attachment 8743620 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good to me. Would be nice to add a comment explaining why you added
> this check.

I'll add a comment before landing, looks like this cleared up 1400 warnings during testing.

Comment 5

[Eric Rahm [:erahm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c47cd2b5f4a6ecfeb4ca629eb335696b5883090b
Bug 1266256 - Don't try to create null URLs in _isMinifiedURL. r=ejpbruel

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out  for various devtools failures 'A promise chain failed to handle a rejection: - [object Object]'.

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/a603640aa82d

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=c47cd2b5f4a6ecfeb4ca629eb335696b5883090b
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=26329764&repo=mozilla-inbound

Comment 7

[Eric Rahm [:erahm]]

(In reply to Sebastian H. [:aryx][:archaeopteryx] from comment #6)
> Backed out  for various devtools failures 'A promise chain failed to handle
> a rejection: - [object Object]'.
> 
> Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/a603640aa82d
> 
> Push with failures:
> https://treeherder.mozilla.org/#/jobs?repo=mozilla-
> inbound&revision=c47cd2b5f4a6ecfeb4ca629eb335696b5883090b
> Failure log:
> https://treeherder.mozilla.org/logviewer.html#?job_id=26329764&repo=mozilla-
> inbound

I have no idea how this code could have caused that. The logic of the function has not been changed, we just avoid emitting a warning now.

Before we would catch the exception and run |MINIFIED_SOURCE_REGEXP.test(...)|, but |MINIFIED_SOURCE_REGEXP.test(null|"")| is going to return false, so just returning false earlier shouldn't be an issue.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This also appears to have busted xpcshell tests: https://treeherder.mozilla.org/logviewer.html#?job_id=26331938&repo=mozilla-inbound

Comment 9

[Eric Rahm [:erahm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7343772993dc

Comment 10

[Eric Rahm [:erahm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2ede1fb0a020b1064bfcefc3e10924eeaccd4542
Bug 1266256 - Don't try to create null URLs in _isMinifiedURL. r=ejpbruel

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2ede1fb0a020