Closed Bug 1266268 Opened 9 years ago Closed 9 years ago

[css-grid] Implement <percentage> for grid gap properties

Categories

(Core :: Layout, defect, P4)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla49
Tracking Flags:
Tracking Status
firefox48 --- affected
firefox49 --- fixed

People

(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(2 files)

fix
12.29 KB, patch
dholbert
: review+
Details | Diff | Splinter Review
tests
17.21 KB, patch
Details | Diff | Splinter Review
https://lists.w3.org/Archives/Public/www-style/2016Apr/0351.html - RESOLVED: Add <percentage> to grid-gap - RESOLVED: Mark the above as at-risk
Attached patch fix — — Splinter Review
Assignee: nobody → mats
Status: NEW → ASSIGNED
Attachment #8754876 - Flags: review?(dholbert)
Attached patch tests — — Splinter Review
Comment on attachment 8754876 [details] [diff] [review] fix Review of attachment 8754876 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks!
Attachment #8754876 - Flags: review?(dholbert) → review+
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/2d60e772249d https://hg.mozilla.org/mozilla-central/rev/1e79a41fdac1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
The percentage of grid-row-gap is based on what size to calculate? In CSS 2.1, margin-top/bottom is based on containing block width.
Depends on: 1279182
Blocks: 1279182
No longer depends on: 1279182
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: