Remove unnecessary compiler version checks for gcc <= 4.8.0 in xpcom

RESOLVED FIXED in Firefox 48

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

unspecified
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox47 wontfix, firefox48 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
Now that we require gcc >= 4.8.5, we can remove these compiler version checks for older gcc versions.

We can also remove the -Wdelete-non-virtual-dtor warning suppression because nsAtomTable.cpp was rewritten and no longer triggers that warning.
Attachment #8743663 - Flags: review?(nfroyd)
Comment on attachment 8743663 [details] [diff] [review]
remove-gcc-version-checks.patch

Review of attachment 8743663 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for cleaning this up.
Comment on attachment 8743663 [details] [diff] [review]
remove-gcc-version-checks.patch

Review of attachment 8743663 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for cleaning this up.
Attachment #8743663 - Flags: review?(nfroyd) → review+

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7df8f4cd5d4a
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
> We can also remove the -Wdelete-non-virtual-dtor warning suppression because
> nsAtomTable.cpp was rewritten and no longer triggers that warning.

\o/
You need to log in before you can comment on or make changes to this bug.