Closed
Bug 1266295
Opened 8 years ago
Closed 8 years ago
Remove unnecessary compiler version checks for gcc <= 4.8.0 in xpcom
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla48
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file)
4.15 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Now that we require gcc >= 4.8.5, we can remove these compiler version checks for older gcc versions. We can also remove the -Wdelete-non-virtual-dtor warning suppression because nsAtomTable.cpp was rewritten and no longer triggers that warning.
Attachment #8743663 -
Flags: review?(nfroyd)
Comment 1•8 years ago
|
||
Comment on attachment 8743663 [details] [diff] [review] remove-gcc-version-checks.patch Review of attachment 8743663 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for cleaning this up.
Comment 2•8 years ago
|
||
Comment on attachment 8743663 [details] [diff] [review] remove-gcc-version-checks.patch Review of attachment 8743663 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for cleaning this up.
Attachment #8743663 -
Flags: review?(nfroyd) → review+
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7df8f4cd5d4a
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment 5•8 years ago
|
||
> We can also remove the -Wdelete-non-virtual-dtor warning suppression because
> nsAtomTable.cpp was rewritten and no longer triggers that warning.
\o/
You need to log in
before you can comment on or make changes to this bug.
Description
•