Closed Bug 1266295 Opened 4 years ago Closed 4 years ago

Remove unnecessary compiler version checks for gcc <= 4.8.0 in xpcom

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox47 --- wontfix
firefox48 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

Now that we require gcc >= 4.8.5, we can remove these compiler version checks for older gcc versions.

We can also remove the -Wdelete-non-virtual-dtor warning suppression because nsAtomTable.cpp was rewritten and no longer triggers that warning.
Attachment #8743663 - Flags: review?(nfroyd)
Comment on attachment 8743663 [details] [diff] [review]
remove-gcc-version-checks.patch

Review of attachment 8743663 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for cleaning this up.
Comment on attachment 8743663 [details] [diff] [review]
remove-gcc-version-checks.patch

Review of attachment 8743663 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for cleaning this up.
Attachment #8743663 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/7df8f4cd5d4a
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
> We can also remove the -Wdelete-non-virtual-dtor warning suppression because
> nsAtomTable.cpp was rewritten and no longer triggers that warning.

\o/
You need to log in before you can comment on or make changes to this bug.