Closed
Bug 1266324
Opened 9 years ago
Closed 9 years ago
NS_STYLE_UNICODE_BIDI_OVERRIDE name isn't consistent with other style const names
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: heycam, Assigned: heycam)
References
Details
Attachments
(1 file)
|
4.36 KB,
patch
|
jfkthame
:
review+
|
Details | Diff | Splinter Review |
NS_STYLE_UNICODE_BIDI_OVERRIDE should really be called NS_STYLE_UNICODE_BIDI_BIDI_OVERRIDE. Renaming it will help stylo's automatically generated property computation methods.
Attachment #8743707 -
Flags: review?(jfkthame)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8743707 [details] [diff] [review]
patch
Review of attachment 8743707 [details] [diff] [review]:
-----------------------------------------------------------------
It's a bit clunky, but if it helps, fine! :)
Attachment #8743707 -
Flags: review?(jfkthame) → review+
|
||
Comment 3•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•