Closed Bug 1266324 Opened 4 years ago Closed 4 years ago

NS_STYLE_UNICODE_BIDI_OVERRIDE name isn't consistent with other style const names

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
NS_STYLE_UNICODE_BIDI_OVERRIDE should really be called NS_STYLE_UNICODE_BIDI_BIDI_OVERRIDE.  Renaming it will help stylo's automatically generated property computation methods.
Attachment #8743707 - Flags: review?(jfkthame)
Comment on attachment 8743707 [details] [diff] [review]
patch

Review of attachment 8743707 [details] [diff] [review]:
-----------------------------------------------------------------

It's a bit clunky, but if it helps, fine! :)
Attachment #8743707 - Flags: review?(jfkthame) → review+
https://hg.mozilla.org/mozilla-central/rev/01cd397e46c4
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.