1266468 - Assertion in nr_ice_media_stream_start_checks caused by incoming STUN request after ICE failure

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect)

Description

[Byron Campen [:bwc]]

We have a few approaches we could use:

1) Deregister the STUN server when the component fails
   - Request is silently discarded

2) Remove the assertion
   - Request gets a 400 response (I think)

3) Check that the component is not failed earlier on
   - Lets us send whatever error code we want

Comment 1

[Byron Campen [:bwc]]

Attachment: MozReview Request: Bug 1266468: Respond to STUN requests with 400 if the component is failed. r?drno

Review commit: https://reviewboard.mozilla.org/r/48215/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/48215/

Comment 2

[Nils Ohlmeier [:drno]]

Comment on attachment 8743973 [details]
MozReview Request: Bug 1266468: Respond to STUN requests with 400 if the component is failed. r?drno

https://reviewboard.mozilla.org/r/48215/#review44913

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3dcce1366518

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3dcce1366518