1266680 - Cloned MediaStreamTracks only stop after all clones and the original have been stopped

Status: VERIFIED FIXED

(Core :: Audio/Video: MediaStreamGraph, defect)

Description

[Andreas Pehrson [:pehrsons]]

Reproduction:
1. See the jsfiddle in the URL
2. Click "gUM me up!"
3. Click "Clone it 100 times!"
4. Click "Stop cloned track" or "Stop original track"

Expected:
Playback of the track for which the stop button was clicked should stop.

Actual:
Playback continues until the other track is also stopped.

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: MozReview Request: Bug 1266680 - Rename BlockTrackId to BlockSourceTrackId. r?jesup

It wasn't clear which TrackID should be passed to MediaInputPort::BlockTrackId(); source or destination.

Review commit: https://reviewboard.mozilla.org/r/48493/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/48493/

Comment 2

[Andreas Pehrson [:pehrsons]]

Attachment: MozReview Request: Bug 1266680 - Fix stopping MediaStreamTrack when there are clones. r?jib

Review commit: https://reviewboard.mozilla.org/r/48495/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/48495/

Comment 3

[Andreas Pehrson [:pehrsons]]

try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd209b495c1f

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8744365 [details]
MozReview Request: Bug 1266680 - Rename BlockTrackId to BlockSourceTrackId. r?jesup

https://reviewboard.mozilla.org/r/48493/#review45195

Comment 5

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8744366 [details]
MozReview Request: Bug 1266680 - Fix stopping MediaStreamTrack when there are clones. r?jib

https://reviewboard.mozilla.org/r/48495/#review45265

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/308b40b4502b
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6d6a9495b77

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/308b40b4502b
https://hg.mozilla.org/mozilla-central/rev/d6d6a9495b77

Comment 8

[Alexandru Simonca [:asimonca], Release Desktop QA]

I have reproduced the steps in the description using Firefox Nightly 48.0a1 (20160420030213) on Windows 10 x64, Ubuntu 14.04 x64 and OSX 10.11. 
The issue is VERIFIED as FIXED on the same OS's in Firefox Beta 48.0b2 (20160620091522).