1266685 - Unnecessary dispatching of queued video frames in MediaPipeline::VideoFrameConverter

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, defect, P2)

Description

[Andreas Pehrson [:pehrsons]]

We are dispatching all video frames coming from the MediaStreamGraph to MediaPipelineTransmit to the VideoFrameConverter TaskQueue.

Once there we check if the frame is identical to a previous frame and discard it.

We should do that check on the MSG thread and avoid the dispatch instead.

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: MozReview Request: Bug 1266685 - Don't pass too many frames to the MediaPipelineTransmit VideoFrameConverter. r?jesup

Review commit: https://reviewboard.mozilla.org/r/48421/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/48421/

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8744255 [details]
MozReview Request: Bug 1266685 - Don't pass too many frames to the MediaPipelineTransmit VideoFrameConverter. r?jesup

https://reviewboard.mozilla.org/r/48421/#review45151

Comment 3

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8744255 [details]
MozReview Request: Bug 1266685 - Don't pass too many frames to the MediaPipelineTransmit VideoFrameConverter. r?jesup

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48421/diff/1-2/

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b12d4b8634f3

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b12d4b8634f3