Closed Bug 1266685 Opened 4 years ago Closed 4 years ago

Unnecessary dispatching of queued video frames in MediaPipeline::VideoFrameConverter

Categories

(Core :: Audio/Video: MediaStreamGraph, defect, P2)

48 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox47 --- unaffected
firefox48 --- fixed

People

(Reporter: pehrsons, Assigned: pehrsons)

References

Details

Attachments

(1 file)

We are dispatching all video frames coming from the MediaStreamGraph to MediaPipelineTransmit to the VideoFrameConverter TaskQueue.

Once there we check if the frame is identical to a previous frame and discard it.

We should do that check on the MSG thread and avoid the dispatch instead.
Attachment #8744255 - Flags: review?(rjesup) → review+
Comment on attachment 8744255 [details]
MozReview Request: Bug 1266685 - Don't pass too many frames to the MediaPipelineTransmit VideoFrameConverter. r?jesup

https://reviewboard.mozilla.org/r/48421/#review45151
Status: NEW → ASSIGNED
Comment on attachment 8744255 [details]
MozReview Request: Bug 1266685 - Don't pass too many frames to the MediaPipelineTransmit VideoFrameConverter. r?jesup

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48421/diff/1-2/
Attachment #8744255 - Attachment description: MozReview Request: Bug 1266685 - Don't pass to many frames to the MediaPipelineTransmit VideoFrameConverter. r?jesup → MozReview Request: Bug 1266685 - Don't pass too many frames to the MediaPipelineTransmit VideoFrameConverter. r?jesup
https://hg.mozilla.org/mozilla-central/rev/b12d4b8634f3
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.