1266899 - Update "available offline" icon

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Some feedback about our current "available offline" icon is that its easy to get confused with many other metaphors as well as being an actionable item. 

I think a simple fix would be to use this (visually more complex) iconography to denote that this is a status rather than an action-able button.

We'll have to update the image in the helper UIs, the panels list, as well as the snackbar.

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Note: bug 1246238 handles the helper UI, and I've attached assets there.

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: icon_downloaded2.zip

Here is the icon for the panel list and the snackbar

Comment 3

[Andrzej Hunt :ahunt]

[Tracking Requested - why for this release]: Tracking for 48 since that's where we landed the reading-list migration.

Comment 4

[Andrzej Hunt :ahunt]

Attachment: bookmarks_new.png

Here's a screenshot of the bookmarks panel with the new icon!

Comment 5

[Andrzej Hunt :ahunt]

Attachment: snackbar_new.png

And the snackbar

Comment 6

[Andrzej Hunt :ahunt]

Attachment: MozReview Request: Bug 1266899 - Update "available offline" icon to use phone instead of arrow r?sebastian

Review commit: https://reviewboard.mozilla.org/r/49261/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/49261/

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8746140 [details]
MozReview Request: Bug 1266899 - Update "available offline" icon to use phone instead of arrow r?sebastian

https://reviewboard.mozilla.org/r/49261/#review46243

Did you verify that the PNGs are minimized? :)

Comment 8

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Comment on attachment 8746134 [details]
bookmarks_new.png

Nice!

Comment 9

[Andrzej Hunt :ahunt]

https://hg.mozilla.org/integration/fx-team/rev/741a8fcef3314464ae380646d52db9f42943fc32
Bug 1266899 - Update "available offline" icon to use phone instead of arrow r=sebastian

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/741a8fcef331

Comment 11

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot from 2016-05-04 11:54:03.png

Verified as fixed using:
Device: Nexus 6 (Android 6.0)
Build: Firefox for Android 49.0a1 (2015-05-03)

Comment 12

[Marcia Knous [:marcia]]

Tracking for 48. Ni on :ahunt - do you want to uplift for 48?

Comment 13

[Andrzej Hunt :ahunt]

Comment on attachment 8746140 [details]
MozReview Request: Bug 1266899 - Update "available offline" icon to use phone instead of arrow r?sebastian

Approval Request Comment
[Feature/regressing bug #]: /
[User impact if declined]: Inconsistent icons between 48 and 49. This icon was introduced in 48, and we'd like to have consistent branding of the offline reader view features between all releases.
[Describe test coverage new/current, TreeHerder]: manual testing.
[Risks and why]: Very low risk: image resource / icon replaced with alternative icon.
[String/UUID change made/needed]: none.

Comment 14

[Andrzej Hunt :ahunt]

(In reply to Marcia Knous [:marcia - use ni] from comment #12)
> Tracking for 48. Ni on :ahunt - do you want to uplift for 48?

Yes, thank you for the reminder - I'm just looking through the various bugs that need uplifting now!

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8746140 [details]
MozReview Request: Bug 1266899 - Update "available offline" icon to use phone instead of arrow r?sebastian

Should be safe, improve our consistency, taking it in aurora.

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/58f539121d2b

Comment 17

[Teodora Vermesan (:TeoVermesan)]

Verified as fixed using:
Device: ONE A2001 (Android 5.1.1)
Build: Firefox for Android 48.0a2 (2015-05-25)