Update "available offline" icon

VERIFIED FIXED in Firefox 48

Status

()

Firefox for Android
General
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: antlam, Assigned: ahunt)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 49
All
Android
Points:
---

Firefox Tracking Flags

(firefox48+ verified, firefox49 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(5 attachments)

(Reporter)

Description

2 years ago
Some feedback about our current "available offline" icon is that its easy to get confused with many other metaphors as well as being an actionable item. 

I think a simple fix would be to use this (visually more complex) iconography to denote that this is a status rather than an action-able button.

We'll have to update the image in the helper UIs, the panels list, as well as the snackbar.
(Reporter)

Comment 1

2 years ago
Note: bug 1246238 handles the helper UI, and I've attached assets there.
(Reporter)

Comment 2

2 years ago
Created attachment 8744527 [details]
icon_downloaded2.zip

Here is the icon for the panel list and the snackbar
(Reporter)

Updated

2 years ago
Flags: needinfo?(ahunt)
(Assignee)

Comment 3

2 years ago
[Tracking Requested - why for this release]: Tracking for 48 since that's where we landed the reading-list migration.
Assignee: nobody → ahunt
tracking-firefox48: --- → ?
Flags: needinfo?(ahunt)
(Assignee)

Comment 4

2 years ago
Created attachment 8746134 [details]
bookmarks_new.png

Here's a screenshot of the bookmarks panel with the new icon!
Flags: needinfo?(alam)
(Assignee)

Comment 5

2 years ago
Created attachment 8746136 [details]
snackbar_new.png

And the snackbar
(Assignee)

Comment 6

2 years ago
Created attachment 8746140 [details]
MozReview Request: Bug 1266899 - Update "available offline" icon to use phone instead of arrow r?sebastian

Review commit: https://reviewboard.mozilla.org/r/49261/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/49261/
Attachment #8746140 - Flags: review?(s.kaspari)
(Assignee)

Updated

2 years ago
Status: NEW → ASSIGNED
Attachment #8746140 - Flags: review?(s.kaspari) → review+
Comment on attachment 8746140 [details]
MozReview Request: Bug 1266899 - Update "available offline" icon to use phone instead of arrow r?sebastian

https://reviewboard.mozilla.org/r/49261/#review46243

Did you verify that the PNGs are minimized? :)
(Reporter)

Comment 8

2 years ago
Comment on attachment 8746134 [details]
bookmarks_new.png

Nice!
Flags: needinfo?(alam)
Attachment #8746134 - Flags: feedback+
(Reporter)

Updated

2 years ago
Attachment #8746136 - Flags: feedback+
(Assignee)

Comment 9

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/741a8fcef3314464ae380646d52db9f42943fc32
Bug 1266899 - Update "available offline" icon to use phone instead of arrow r=sebastian

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/741a8fcef331
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Created attachment 8748532 [details]
Screenshot from 2016-05-04 11:54:03.png

Verified as fixed using:
Device: Nexus 6 (Android 6.0)
Build: Firefox for Android 49.0a1 (2015-05-03)
status-firefox49: fixed → verified
Tracking for 48. Ni on :ahunt - do you want to uplift for 48?
status-firefox48: --- → affected
tracking-firefox48: ? → +
Flags: needinfo?(ahunt)
(Assignee)

Comment 13

2 years ago
Comment on attachment 8746140 [details]
MozReview Request: Bug 1266899 - Update "available offline" icon to use phone instead of arrow r?sebastian

Approval Request Comment
[Feature/regressing bug #]: /
[User impact if declined]: Inconsistent icons between 48 and 49. This icon was introduced in 48, and we'd like to have consistent branding of the offline reader view features between all releases.
[Describe test coverage new/current, TreeHerder]: manual testing.
[Risks and why]: Very low risk: image resource / icon replaced with alternative icon.
[String/UUID change made/needed]: none.
Flags: needinfo?(ahunt)
Attachment #8746140 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 14

2 years ago
(In reply to Marcia Knous [:marcia - use ni] from comment #12)
> Tracking for 48. Ni on :ahunt - do you want to uplift for 48?

Yes, thank you for the reminder - I'm just looking through the various bugs that need uplifting now!
Comment on attachment 8746140 [details]
MozReview Request: Bug 1266899 - Update "available offline" icon to use phone instead of arrow r?sebastian

Should be safe, improve our consistency, taking it in aurora.
Attachment #8746140 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 16

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/58f539121d2b
status-firefox48: affected → fixed
Verified as fixed using:
Device: ONE A2001 (Android 5.1.1)
Build: Firefox for Android 48.0a2 (2015-05-25)
Status: RESOLVED → VERIFIED
status-firefox48: fixed → verified
You need to log in before you can comment on or make changes to this bug.