1266922 - Remove checking "visibilitychange" reason from ActionBarHandler.js

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

File per bug 1249201 comment 45.

Do some testing for the floating toolbar after removing "visibilitychange" in [1], and if nothing broken, we can remove it.

I think the key to test here is to think of other cases we need the floating toolbar to be closed while carets are visible besides scrolling the carets and dragging a caret we had considered. I cannot come up with other cases  off the top of my head.
 
[1] https://dxr.mozilla.org/mozilla-central/rev/0891f0fa044cba28024849803e170ed7700e01e0/mobile/android/chrome/content/ActionBarHandler.js#68

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1266922 - Remove checking "visibilitychange" reason from ActionBarHandler.js.

After bug 1249201 landed, the "visibilitychange" reason wasn't
dispatched during scrolling anymore. See bug 1249201 comment 44 for the
reasoning.

Review commit: https://reviewboard.mozilla.org/r/62596/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62596/

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8768283 [details]
Bug 1266922 - Remove checking "visibilitychange" reason from ActionBarHandler.js.

https://reviewboard.mozilla.org/r/62596/#review59332

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7cd947b360b8
Remove checking "visibilitychange" reason from ActionBarHandler.js. r=sebastian

Comment 4

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/7cd947b360b8