1266948 - text-decoration-color: currentcolor should not use value from -webkit-text-fill-color

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[u459114]

text-decoration-color is using value from -webkit-text-fill-color after Bug 1261578 landed.

According to bug 1261578 comment 77, this behavior is not correct. So we need to
1. Back out the change in "Part 2. Correct text decoration color;"
2. Modify test cases of text decoration in "Bug 1261578 - Part 5. web-platform-test reftest;" from respect -webkit-text-fill-color to not respect -webkit-text-fill-color.

Comment 3

[Jonathan Kew [:jfkthame]]

Comment on attachment 8744593 [details]
MozReview Request: Bug 1266948 - text-decoration-color: currentcolor should not use value from -webkit-text-fill-color;

https://reviewboard.mozilla.org/r/48635/#review45507

This also needs to back out a change from nsComputedDOMStyle.cpp, AFAICT.

Comment 4

[u459114]

Comment on attachment 8744593 [details]
MozReview Request: Bug 1266948 - text-decoration-color: currentcolor should not use value from -webkit-text-fill-color;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48635/diff/2-3/

Comment 5

[u459114]

https://reviewboard.mozilla.org/r/48635/#review45507

Done

Comment 6

[u459114]

[Tracking Requested - why for this release]:

Comment 7

[u459114]

[Tracking Requested - why for this release]:
text-decoration-color:currentcolor now use value from -webkit-text-fill-color after a patch in bug 1261578 landed. We need the patch in this bug land to correct that behavior

Comment 8

[Jonathan Kew [:jfkthame]]

Comment on attachment 8744593 [details]
MozReview Request: Bug 1266948 - text-decoration-color: currentcolor should not use value from -webkit-text-fill-color;

https://reviewboard.mozilla.org/r/48635/#review45795

Comment 9

[u459114]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=68cba10a5785

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/24fd925eb06d

Comment 12

[u459114]

Comment on attachment 8744593 [details]
MozReview Request: Bug 1266948 - text-decoration-color: currentcolor should not use value from -webkit-text-fill-color;

Approval Request Comment
[Feature/regressing bug #]:Bug 1261578.
[User impact if declined]: Wrong text decoration color
[Describe test coverage new/current, TreeHerder]: A reftest in the patch.
[Risks and why]: risk-low.
[String/UUID change made/needed]: N/A

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/24fd925eb06d

Comment 14

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8744593 [details]
MozReview Request: Bug 1266948 - text-decoration-color: currentcolor should not use value from -webkit-text-fill-color;

Fixes a recent regression, baked in Nightly for a week, Aurora48+

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/02263fffb04d