text-decoration-color: currentcolor should not use value from -webkit-text-fill-color

RESOLVED FIXED in Firefox 48

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: u459114, Assigned: u459114)

Tracking

({regression})

Trunk
mozilla49
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox47 unaffected, firefox48+ fixed, firefox49 fixed)

Details

Attachments

(1 attachment)

text-decoration-color is using value from -webkit-text-fill-color after Bug 1261578 landed.

According to bug 1261578 comment 77, this behavior is not correct. So we need to
1. Back out the change in "Part 2. Correct text decoration color;"
2. Modify test cases of text decoration in "Bug 1261578 - Part 5. web-platform-test reftest;" from respect -webkit-text-fill-color to not respect -webkit-text-fill-color.
Assignee: nobody → cku
Attachment #8744593 - Flags: review?(jfkthame)
Attachment #8744593 - Flags: review?(jfkthame)
Comment on attachment 8744593 [details]
MozReview Request: Bug 1266948 - text-decoration-color: currentcolor should not use value from -webkit-text-fill-color;

https://reviewboard.mozilla.org/r/48635/#review45507

This also needs to back out a change from nsComputedDOMStyle.cpp, AFAICT.
Comment on attachment 8744593 [details]
MozReview Request: Bug 1266948 - text-decoration-color: currentcolor should not use value from -webkit-text-fill-color;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48635/diff/2-3/
Attachment #8744593 - Flags: review?(jfkthame)
[Tracking Requested - why for this release]:
[Tracking Requested - why for this release]:
text-decoration-color:currentcolor now use value from -webkit-text-fill-color after a patch in bug 1261578 landed. We need the patch in this bug land to correct that behavior
Comment on attachment 8744593 [details]
MozReview Request: Bug 1266948 - text-decoration-color: currentcolor should not use value from -webkit-text-fill-color;

https://reviewboard.mozilla.org/r/48635/#review45795
Attachment #8744593 - Flags: review?(jfkthame) → review+
Comment on attachment 8744593 [details]
MozReview Request: Bug 1266948 - text-decoration-color: currentcolor should not use value from -webkit-text-fill-color;

Approval Request Comment
[Feature/regressing bug #]:Bug 1261578.
[User impact if declined]: Wrong text decoration color
[Describe test coverage new/current, TreeHerder]: A reftest in the patch.
[Risks and why]: risk-low.
[String/UUID change made/needed]: N/A
Attachment #8744593 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/24fd925eb06d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Target Milestone: mozilla48 → mozilla49
Comment on attachment 8744593 [details]
MozReview Request: Bug 1266948 - text-decoration-color: currentcolor should not use value from -webkit-text-fill-color;

Fixes a recent regression, baked in Nightly for a week, Aurora48+
Attachment #8744593 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.