126701 - mozTXTToHTMLConv speed for english

Status: RESOLVED INVALID

(MailNews Core :: Backend, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

streamconv was rewritten in bug 26915 for speed, but the final rewrite had a
slowdown (considerable) from the initial patch when converting english text. 
This should be checked and perhaps corrected as per mscott's bug comments when
he checked in the code.  I assume this is a perf issue for mailnews display of text.

Comment 1

[Scott MacGregor]

that comment about those timing was from 2 years ago. The comment is definetly
obsolete now. This wasn't showing up as a hot spot in any of my quantify logs
for message display. Pushing out to something to look at in the future. 

Comment 2

[Ben Bucksch (:BenB)]

s/streamconv/mozTXTToHTMLConv/

I'm persoanlly not keen on reopening the issue, but it would be nice to see the
class use string classes again, without noticable perf decrease. So, if anybody
wants to do the work, you have my support, assuming you don't introduce new bugs.

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

If someone can tell me a test that would exercise this (real-world, like
"display this 10000-line english text email) I can trivially get a jprof on it.

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

see also bug 21203 (for reference)

Comment 5

[Ben Bucksch (:BenB)]

jesup, there are test cases in bug 26915.

Comment 6

[Mike Cowperthwaite]

Moving a bunch of mozTXTToHTMLConv bugs into Core / MailNews Backend to live 
with their bretheren.

Comment 7

[Wayne Mery (:wsmwk)]

closing per mscott