Closed
Bug 1267012
Opened 8 years ago
Closed 8 years ago
Timebomb failure in test_signed_dir.js
Categories
(Core :: Security: PSM, defect, P1)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla52
People
(Reporter: philor, Assigned: Cykesiopka)
References
Details
(Whiteboard: [psm-assigned])
Attachments
(1 file)
Apparently despite bug 842064 making us think that the -v 480 was giving us signing certs that would expire in 40 years, something used by test_signed_dir.js expired after one year, so I'm disabling it on every branch.
Reporter | ||
Comment 2•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/2b7291cc565421eebd5328f09dede6ff40ce0b42 https://hg.mozilla.org/releases/mozilla-release/rev/0f1d5ce151c41b82219404dbb9f3bc9c46e0c0d0 https://hg.mozilla.org/releases/mozilla-esr45/rev/6a695027eb1c8c9aa2a39321273932d04348cf6c
status-firefox46:
--- → disabled
status-firefox47:
--- → disabled
status-firefox48:
--- → disabled
status-firefox-esr38:
--- → unaffected
status-firefox-esr45:
--- → disabled
Updated•8 years ago
|
Depends on: armagadd-on
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → cykesiopka.bmo
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [psm-assigned]
Assignee | ||
Updated•8 years ago
|
Component: Security → Security: PSM
Comment hidden (mozreview-request) |
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8801761 [details] Bug 1267012 - Update and re-enable test_signed_dir.js. https://reviewboard.mozilla.org/r/86418/#review85172 Great - r=me. Just some comments. ::: security/manager/ssl/tests/unit/test_signed_dir.js:1 (Diff revision 1) > "use strict"; Should we add a license block? ::: security/manager/ssl/tests/unit/test_signed_dir.js:15 (Diff revision 1) > -const certdb = Cc["@mozilla.org/security/x509certdb;1"].getService(Ci.nsIX509CertDB); > +const certdb = Cc["@mozilla.org/security/x509certdb;1"] > + .getService(Ci.nsIX509CertDB); > > -var gSignedXPI = do_get_file("test_signed_apps/sslcontrol.xpi", false); > +/** > + * Signed test extension. This is any arbitrary Mozilla signed XPI that > + * preferably has recently been signed. Might add a comment that it actually doesn't matter, since we ignore expired certificates when checking signing. ::: security/manager/ssl/tests/unit/test_signed_dir.js:47 (Diff revision 1) > +/** > + * Extracts the signed XPI into a directory, and tampers the files in that > + * directory if instructed. > + * > + * @param {TamperInstructions} tamper > + * Instructions on whether to tamper any files, and is so, how. typo: "if so"
Attachment #8801761 -
Flags: review?(dkeeler) → review+
Assignee | ||
Comment 5•8 years ago
|
||
mozreview-review-reply |
Comment on attachment 8801761 [details] Bug 1267012 - Update and re-enable test_signed_dir.js. https://reviewboard.mozilla.org/r/86418/#review85172 Thanks! > Should we add a license block? Sure. PD seems the most appropriate for this file. > Might add a comment that it actually doesn't matter, since we ignore expired certificates when checking signing. Done. > typo: "if so" Fixed.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 7•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bac1754d8d226130072087c9581b61755acb896a The SM(arm) and SM(p) failures look unrelated - probably already present in the base commit I used.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/debc3dfbc36a Update and re-enable test_signed_dir.js. r=keeler
Keywords: checkin-needed
Reporter | ||
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/debc3dfbc36a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•