126709 - initialize mLCID at the start of ::Initialize() [nsDateTimeFormatterWin.cpp]

Status: RESOLVED INVALID

(Core :: Internationalization, defect)

Description

[(not reading, please use [e-mail] instead)]

spun off from bug #126677

another fix is to move the default initialization of the LCID to the top of
::Initialize - do we ever want to return out of this routine without setting 
this?

 // default LCID (en-US)
  mLCID = 1033;

Naoki, besides the usual suspects wreaking general string havoc on this file, it
looks like you're the i18n guy who knows what's going on here. Could you look at
the ::Initialize routine and say whether we should be setting mLCID at the top
of the routine?

Comment 1

[Rui Xu]

Should IQA be involved in this bug? 

Comment 2

[nhottanscp]

The default value 1033 is for the case failing to get the value from WinAPI.
I cannot move it to the top of the function because it would override the value
already set. Let me move it to the constructor.

BTW, I don't understand the requirement of checking the length before calling
nsString::Equals. It sould be able to compare against an empty string.

Comment 3

[Alec Flett]

naoki: the old code (Before my global string changes yesterday) had the
.Length() test - I (stupidly) removed it thinking it was inconsequential. I
think the idea is that in this code (nsDateTimeFormatWin) two empty strings
should not be considered equal...

That said, the .Length() test should really be .IsEmpty().. when you fix this
please replace that test as well.. thanks!

Comment 4

[nhottanscp]

Okay, thanks for the explanation.

Comment 5

[nhottanscp]

I think I should also set mLocale to "en-US" at the constructor then no empty
check needed later.

Comment 6

[Frank Tang]

both naoki and I are off mozilla for about 20 monthes. If these bugs are still
here, the real status is 'wont fix'. If you want to reopen it, please find a
better owner who really looking at the bug database now. 

Comment 7

[Travis Chase]

Mass Reassign Please excuse the spam

Comment 8

[Travis Chase]

Mass Re-opening Bugs Frank Tang Closed on Wensday March 02 for no reason, all
the spam is his fault feel free to tar and feather him

Comment 9

[Travis Chase]

Reassigning Franks old bugs to Jungshik Shin for triage - Sorry for spam