1267100 - "Assertion failure: IsCurrent()" in mozilla::gl::GLContext::BeforeGLCall

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Jerry Shih[:jerry] (UTC+8) (inactive)]

I will work on this.

Comment 3

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: P1: add makeCurrent() for WebGLContext::GetFramebufferAttachmentParameter(). v1

I think we miss the makeCurrent() call.

Comment 4

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: P2: test case for webgl getFramebufferAttachmentParameter() call. v1

Comment 5

[Jerry Shih[:jerry] (UTC+8) (inactive)]

try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e08e187e86d0

Comment 6

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Please land the attachment 8745183 [details] [diff] [review] and attachment 8745184 [details] [diff] [review] to m-c.
try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e08e187e86d0

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/de77b0c64ad9
https://hg.mozilla.org/integration/mozilla-inbound/rev/f72ce6c9ec3f

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for unexpected passes in test_conformance__glsl__misc__shaders-with-name-conflicts.html

Backouts:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1fa73458c212
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ff462dbae75

Push with issues: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=54b1f93e6b73e40cbf04dbb2f03d37714b89f695
Log: https://treeherder.mozilla.org/logviewer.html#?job_id=26730703&repo=mozilla-inbound
08:57:57     INFO -  589 INFO TEST-START | dom/canvas/test/webgl-conf/generated/test_conformance__glsl__misc__shaders-with-name-conflicts.html
08:57:57     INFO -  JavaScript warning: http://mochi.test:8888/tests/dom/canvas/test/webgl-conf/checkout/conformance/resources/glsl-conformance-test.js, line 169: Error: WebGL: linkProgram: Failed to link, leaving the following log:
08:57:57     INFO -  The uniform name (foo) conflicts with attribute name.
08:57:57     INFO -  590 INFO TEST-FAIL | dom/canvas/test/webgl-conf/generated/test_conformance__glsl__misc__shaders-with-name-conflicts.html | A valid string reason is expected
08:57:57     INFO -  591 INFO TEST-FAIL | dom/canvas/test/webgl-conf/generated/test_conformance__glsl__misc__shaders-with-name-conflicts.html | Reason cannot be empty
08:57:57     INFO -  592 INFO TEST-FAIL | dom/canvas/test/webgl-conf/generated/test_conformance__glsl__misc__shaders-with-name-conflicts.html | shaders with conflicting uniform/attribute names should fail
08:57:57     INFO -  593 INFO TEST-FAIL | dom/canvas/test/webgl-conf/generated/test_conformance__glsl__misc__shaders-with-name-conflicts.html | successfullyParsed is true
08:57:57     INFO -  594 INFO TEST-UNEXPECTED-PASS | dom/canvas/test/webgl-conf/generated/test_conformance__glsl__misc__shaders-with-name-conflicts.html | fail-if condition in manifest - We expected at least one failure

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7b63f81d72fb
https://hg.mozilla.org/integration/mozilla-inbound/rev/a4a7d5ed6da1

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Unfortunately, the backouts weren't necessary. The WebGL errors had been caused by a different patch, so I relanded these.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7b63f81d72fb
https://hg.mozilla.org/mozilla-central/rev/a4a7d5ed6da1