1267209 - Converting the existing flags parameter of nsLayoutUtils::PaintFrame to an enum class

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[u459114]

According to Bug 1265715 comment 20, 
converted the existing flags parameter of nsLayoutUtils::PaintFrame to an enum class:
  static nsresult PaintFrame(nsRenderingContext* aRenderingContext, 
                             nsIFrame* aFrame,
                             const nsRegion& aDirtyRegion, nscolor aBackstop,
                             uint32_t aFlags = 0)

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: MozReview Request: Bug 1267209 - Convert nsLayoutUtils::PaintFrame flags to be an enum class.

Review commit: https://reviewboard.mozilla.org/r/49023/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/49023/

Comment 2

[Jonathan Kew [:jfkthame]]

Comment on attachment 8745374 [details]
MozReview Request: Bug 1267209 - Convert nsLayoutUtils::PaintFrame flags to be an enum class.

https://reviewboard.mozilla.org/r/49023/#review45827

Looks fine, thanks! Just one request: please name the enum class "nsLayoutUtils::PaintFrameFlags" (plural), following the pattern of other ...Flags types we have in layout. (It's a bit-set in which multiple flags can be independently set/cleared, not just a single flag.)

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

https://reviewboard.mozilla.org/r/49023/#review45827

No problem. nsLayoutUtils::PaintFrameFlags is a better name.

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Comment on attachment 8745374 [details]
MozReview Request: Bug 1267209 - Convert nsLayoutUtils::PaintFrame flags to be an enum class.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49023/diff/1-2/

Comment 5

[Jonathan Kew [:jfkthame]]

Comment on attachment 8745374 [details]
MozReview Request: Bug 1267209 - Convert nsLayoutUtils::PaintFrame flags to be an enum class.

https://reviewboard.mozilla.org/r/49023/#review45965

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b2d671e60eea

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b2d671e60eea