1267253 - Delete gfxWindowsPlatform::RenderMode and replace it with a check against the default backend

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Mason Chang [Inactive] [:mchang]]

Delete references to gfxWindowsPlatform::RenderMode [1] since it assumes we use d2d as long as it's available, but we could still not use d2d if the backend prefs are different. This is causing some skia reftest failures.

[1] https://dxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxWindowsPlatform.h?case=true&from=gfxWindowsPlatform.h#123

Comment 1

[Mason Chang [Inactive] [:mchang]]

Attachment: Delete gfxWindowsPlatform::RenderMode

Try looks good I think - https://treeherder.mozilla.org/#/jobs?repo=try&revision=1bdc470cdf39 - #releng said we can ignore the windows 7 gfx vms.

Comment 2

[Bas Schouten (:bas.schouten)]

Comment on attachment 8744909 [details] [diff] [review]
Delete gfxWindowsPlatform::RenderMode

Review of attachment 8744909 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxUtils.cpp
@@ +400,5 @@
>  static CompositionOp
>  OptimalFillOp()
>  {
>  #ifdef XP_WIN
> +    if (gfxWindowsPlatform::GetPlatform()->IsDirect2DBackend()) {

We should really base this on the DT we're actually drawing to. But that should be a follow-up.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/32ea86eb7d9f

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/32ea86eb7d9f

Comment 6

[Milan Sreckovic [:milan] (needinfo for best results)]

If I force CreateBlendState() to fail in CompositorD3D11::Initialize() (just return false, regardless of the result of that call), I end up with D2D and basic compositor.  Is that a result of this patch, or was it bad before?

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

Backed out this patch, this is still there.  I'll open a bug.

Comment 8

[Milan Sreckovic [:milan] (needinfo for best results)]

Opened bug 1268628