Closed Bug 1267293 Opened 8 years ago Closed 8 years ago

The DOM panel should be off by default

Categories

(DevTools :: DOM, defect)

defect
Not set
normal

Tracking

(firefox48+ fixed, firefox49 fixed)

RESOLVED FIXED
Firefox 49
Tracking Status
firefox48 + fixed
firefox49 --- fixed

People

(Reporter: Honza, Assigned: Honza)

References

Details

Attachments

(2 files)

The DOM panel should be hidden by default.

(later we can discuss how to make it on for Firebug users).

Honza
Attached patch bug1267293.patchSplinter Review
Assignee: nobody → odvarko
Status: NEW → ASSIGNED
Attachment #8744947 - Flags: review?(bgrinstead)
Attachment #8744947 - Flags: review?(bgrinstead) → review+
Fixing tests, let's see what the try says first.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=699d437a3a5f

Honza
Attachment #8744955 - Flags: review?(bgrinstead)
Comment on attachment 8744955 [details] [diff] [review]
bug1267293-tests.patch

Review of attachment 8744955 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me if tests are green
Attachment #8744955 - Flags: review?(bgrinstead) → review+
[Tracking Requested - why for this release]: Need to make sure this new devtools panel doesn't stay turned on by default unintentionally
Try looks good - can you fold them together and push to fx-team / do checkin-needed when you get a chance?
Flags: needinfo?(odvarko)
Never mind, I went ahead and folded/pushed
Flags: needinfo?(odvarko)
https://hg.mozilla.org/mozilla-central/rev/7d48a5e12f18
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Target Milestone: Firefox 48 → Firefox 49
Comment on attachment 8744947 [details] [diff] [review]
bug1267293.patch

Approval Request Comment
[Feature/regressing bug #]: 1201475
[User impact if declined]: A new devtools panel will be visible by default in Firefox 49 that we didn't intend to be
[Describe test coverage new/current, TreeHerder]: Tests confirm that the panel was on but is now off after
[Risks and why]: Low -- hiding new functionality

Note the changeset for uplift was a folded patch: https://hg.mozilla.org/mozilla-central/rev/7d48a5e12f18
Attachment #8744947 - Flags: approval-mozilla-aurora?
Component: Developer Tools → Developer Tools: DOM
Hi Ritu, if possible I'd like to get this uplifted before we start shipping Dev Edition 48 so that we aren't turning on this panel on accident.  Can you please take a look at the uplift request when you have a chance?
Flags: needinfo?(rkothari)
Comment on attachment 8744947 [details] [diff] [review]
bug1267293.patch

Devtools panel, not planned for 48, will be on by default, Aurora48+
Flags: needinfo?(rkothari)
Attachment #8744947 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Hi, I only just saw this and we turned on updates for aurora around 4:30pm today.  If you can land this it would be in tomorrow's aurora build. I can also throttle updates again to 0 if you think it is worth doing.
Flags: needinfo?(bgrinstead)
In reply to Brian Grinstead [:bgrins] from comment #10)
> Hi Ritu, if possible I'd like to get this uplifted before we start shipping
> Dev Edition 48 so that we aren't turning on this panel on accident.  Can you
> please take a look at the uplift request when you have a chance?

Sure. Hi Wes, Carsten, could you please uplift this patch to Aurora asap? Thanks!
Flags: needinfo?(wkocher)
Flags: needinfo?(cbook)
I went ahead and pushed to aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/6e453fe828bf
Flags: needinfo?(wkocher)
Flags: needinfo?(cbook)
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #12)
> Hi, I only just saw this and we turned on updates for aurora around 4:30pm
> today.  If you can land this it would be in tomorrow's aurora build. I can
> also throttle updates again to 0 if you think it is worth doing.

I think if the update goes out tomorrow morning it will be OK
Flags: needinfo?(bgrinstead)
Tracking in case this reopens.
The bug was about to hidden the dom pannel by default.I have seen the features implemented with firefox 48.0b10 on windows 10 ,32 bit
This bug's fix is verified on Latest beta 48.0b10

Build ID:20160721144529
User Agent:Mozilla/5.0 (Windows NT 10.0; rv:48.0) Gecko/20100101 Firefox/48.0

[testday-20160722]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.