1267293 - The DOM panel should be off by default

Status: RESOLVED FIXED

(DevTools :: DOM, defect)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

The DOM panel should be hidden by default.

(later we can discuss how to make it on for Firebug users).

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: bug1267293.patch

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: bug1267293-tests.patch

Fixing tests, let's see what the try says first.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=699d437a3a5f

Honza

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8744955 [details] [diff] [review]
bug1267293-tests.patch

Review of attachment 8744955 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me if tests are green

Comment 4

[Brian Grinstead [:bgrins]]

[Tracking Requested - why for this release]: Need to make sure this new devtools panel doesn't stay turned on by default unintentionally

Comment 5

[Brian Grinstead [:bgrins]]

Try looks good - can you fold them together and push to fx-team / do checkin-needed when you get a chance?

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/7d48a5e12f18

Comment 7

[Brian Grinstead [:bgrins]]

Never mind, I went ahead and folded/pushed

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7d48a5e12f18

Comment 9

[Brian Grinstead [:bgrins]]

Comment on attachment 8744947 [details] [diff] [review]
bug1267293.patch

Approval Request Comment
[Feature/regressing bug #]: 1201475
[User impact if declined]: A new devtools panel will be visible by default in Firefox 49 that we didn't intend to be
[Describe test coverage new/current, TreeHerder]: Tests confirm that the panel was on but is now off after
[Risks and why]: Low -- hiding new functionality

Note the changeset for uplift was a folded patch: https://hg.mozilla.org/mozilla-central/rev/7d48a5e12f18

Comment 10

[Brian Grinstead [:bgrins]]

Hi Ritu, if possible I'd like to get this uplifted before we start shipping Dev Edition 48 so that we aren't turning on this panel on accident.  Can you please take a look at the uplift request when you have a chance?

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8744947 [details] [diff] [review]
bug1267293.patch

Devtools panel, not planned for 48, will be on by default, Aurora48+

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Hi, I only just saw this and we turned on updates for aurora around 4:30pm today.  If you can land this it would be in tomorrow's aurora build. I can also throttle updates again to 0 if you think it is worth doing.

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

In reply to Brian Grinstead [:bgrins] from comment #10)
> Hi Ritu, if possible I'd like to get this uplifted before we start shipping
> Dev Edition 48 so that we aren't turning on this panel on accident.  Can you
> please take a look at the uplift request when you have a chance?

Sure. Hi Wes, Carsten, could you please uplift this patch to Aurora asap? Thanks!

Comment 14

[Brian Grinstead [:bgrins]]

I went ahead and pushed to aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/6e453fe828bf

Comment 15

[Brian Grinstead [:bgrins]]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #12)
> Hi, I only just saw this and we turned on updates for aurora around 4:30pm
> today.  If you can land this it would be in tomorrow's aurora build. I can
> also throttle updates again to 0 if you think it is worth doing.

I think if the update goes out tomorrow morning it will be OK

Comment 16

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking in case this reopens.

Comment 17

[Nawaf Chowdhury Akash]

The bug was about to hidden the dom pannel by default.I have seen the features implemented with firefox 48.0b10 on windows 10 ,32 bit
This bug's fix is verified on Latest beta 48.0b10

Build ID:20160721144529
User Agent:Mozilla/5.0 (Windows NT 10.0; rv:48.0) Gecko/20100101 Firefox/48.0

[testday-20160722]