Closed
Bug 1267312
Opened 8 years ago
Closed 8 years ago
A mochitest to verify that when text-decoration-color is currentColor, getComputedStyle().getPropertyValue('text-decoration-color') should return color instead of -webkit-text-fill-color
Categories
(Core :: Layout: Text and Fonts, defect)
Core
Layout: Text and Fonts
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: u459114, Assigned: u459114)
Details
Attachments
(2 files)
As title
Summary: A mochitest to verify that when when text-decoration-color is currentColor, getComputedStyle().getPropertyValue('text-decoration-color') should return color instead of -webkit-text-fill-color → A mochitest to verify that when text-decoration-color is currentColor, getComputedStyle().getPropertyValue('text-decoration-color') should return color instead of -webkit-text-fill-color
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
Attachment #8794976 -
Flags: review?(jfkthame)
Attachment #8794977 -
Flags: review?(jfkthame)
|
||
Comment 5•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8794976 [details] Bug 1267312 - Part 1. A mochitest to verify that when text-decoration-color is currentColor, the value of it should be the same with color prop. https://reviewboard.mozilla.org/r/81174/#review79914 ::: testing/web-platform/tests/compat/webkit-text-fill-color-currentColor.html:2 (Diff revision 2) > +<!doctype html> > +<title>Test -webkit-text-fill-color</title> Very minor... the title could be a bit more specific, like "Test that currentColor is not affected by -webkit-text-fill-color" or something.
Attachment #8794976 -
Flags: review?(jfkthame) → review+
|
|
||
Comment 6•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8794977 [details] Bug 1267312 - Part 2. update MANIFEST.json. https://reviewboard.mozilla.org/r/81176/#review79916
Attachment #8794977 -
Flags: review?(jfkthame) → review+
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
Pushed by cku@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/114ea1bc2c23 Part 1. A mochitest to verify that when text-decoration-color is currentColor, the value of it should be the same with color prop. r=jfkthame https://hg.mozilla.org/integration/autoland/rev/23c3dc155f73 Part 2. update MANIFEST.json. r=jfkthame
|
||
Comment 10•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/114ea1bc2c23 https://hg.mozilla.org/mozilla-central/rev/23c3dc155f73
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
|
||
Comment 11•8 years ago
|
||
This test is actually not correct given the current spec, since currentcolor itself is a computed value, and consequently getComputedStyle should return the keyword rather than the color value. But we can probably ask spec to change.
For compatibility, I'm reasonably confident that the spec needs to require that getComputedStyle() for a currentcolor value needs to return a color rather than the currentcolor keyword.
You need to log in
before you can comment on or make changes to this bug.
Description
•