Closed Bug 1267347 Opened 4 years ago Closed 3 years ago

Editing the Dev-Events Form to be current

Categories

(bugzilla.mozilla.org :: Custom Bug Entry Forms, defect)

Production
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: spersing, Assigned: callahad)

References

()

Details

Attachments

(1 file, 2 obsolete files)

This form is outdated and need fields to be update. 

Specifically, the Products section:
Which Mozilla products/projects are most relevant to this event?
Please select all that apply. See mozilla.org/products for more information about Mozilla products.

Firefox Web Browser
Encryption
Web Assembly/Platform
Rust
Servo  
webVR
The Free and Open Web
Developer Tools

Question:
If requesting sponsorship, what amount/level do you suggest?
Include Sponsorship Amounts and quick summary of benefits. 
Should be edited to List the tiers of sponsorship amount and benefit that we can review.

I can submit a more detailed edit document.
Assignee: nobody → dylan
Hi Dylan

Let me know what I need to do to get this bug form updated.
Thanks!
Sandra
I think I have enough info -- I'll get something up on dev shortly for review.
I am sorry, there was higher-priority work on a component for the security team, which has been taking most of my attention.
That work is almost done and I'll update this bug shortly with the status of this form.
(In reply to Dylan William Hardison [:dylan] from comment #3)
> I am sorry, there was higher-priority work on a component for the security
> team, which has been taking most of my attention.
> That work is almost done and I'll update this bug shortly with the status of
> this form.

Hi Dylan, Following up to see if I can get an ETA on progress please. Thanks
Flags: needinfo?(dylan)
I'll have a revised ETA by the end of the day :-)
Flags: needinfo?(dylan)
Attached patch 1267347_2.patch (obsolete) — Splinter Review
Uploading patch for safe keeping. I've commited the changes to bugzilla dev and I'll update the bug when they're ready to view.
I nearly forgot -- what are the tiers of "sponsorship amount and benefit that we can review."? I looked on mana and some related places but I couldn't make heads or tails of what that list should be.
Flags: needinfo?(spersing)
(In reply to Dylan William Hardison [:dylan] from comment #7)
> I nearly forgot -- what are the tiers of "sponsorship amount and benefit
> that we can review."? I looked on mana and some related places but I
> couldn't make heads or tails of what that list should be.

Hi Dylan,
This should be an open text field for the person filing the bug to input this information (since it varies per event request).

Thanks
Sandra
Flags: needinfo?(spersing)
Including stakeholder, Jason Weathersby, to be able to view the Dev Events Sponsorship form revision process.
Attached patch 1267347_3.patch (obsolete) — Splinter Review
This should also be up on the dev instance in a few minutes. My next comment will include instructions for testing it out there.
Attachment #8752402 - Attachment is obsolete: true
Attachment #8756316 - Flags: review?(dkl)
Comment on attachment 8756316 [details] [diff] [review]
1267347_3.patch

Review of attachment 8756316 [details] [diff] [review]:
-----------------------------------------------------------------

Javascript error when submitting. Need to update product list in the dev_engagement.js file as well.

https://github.com/mozilla/webtools-bmo-bugzilla/blob/master/extensions/BMO/web/js/dev_engagement.js#L113

::: extensions/BMO/template/en/default/bug/create/create-dev-engagement-event.html.tmpl
@@ +337,5 @@
> +  <label for="product_servo">Servo</label><br>
> +
> +  <input type="checkbox" name="product_webvr" id="product_webvr">
> +  <label for="product_webvr">webVR</label><br>
> +  

Remove whitespace

@@ +462,4 @@
>      If requesting sponsorship, what amount/level do you suggest?
>    </div>
>    <div class="field_desc">
> +    Include Sponsorship Amounts and quick summary of benefits. 

whitespacce
Attachment #8756316 - Flags: review?(dkl) → review-
Assigning to myself to update the patch; will re-assign to :dylan once that's ready.
Assignee: dylan → dan.callahan
Status: NEW → ASSIGNED
Attached patch 1267347_4.patchSplinter Review
Addressed review comments. Flagging :dylan for r?
Attachment #8756316 - Attachment is obsolete: true
Attachment #8785332 - Flags: review?(dylan)
Comment on attachment 8785332 [details] [diff] [review]
1267347_4.patch

Looks good  to me -- tried a few variations. I'll push this up to bugzilla-dev so you can test it out to check for any last-minute changes.

r=dylan
Flags: needinfo?(dan.callahan)
Attachment #8785332 - Flags: review?(dylan) → review+
the new form is live on bugzilla-dev.
I assume this is good, it will be live next week.
Flags: needinfo?(dan.callahan)
To git@github.com:mozilla-bteam/bmo.git
   80b9c88..a2f813d  master -> master
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
This change was pushed live today.

dkl
You need to log in before you can comment on or make changes to this bug.